-
Notifications
You must be signed in to change notification settings - Fork 268
CLI vs VS no-op does not work with pruning & central package management in all cases #14840
Copy link
Copy link
Closed
NuGet/NuGet.Client
#7250Labels
Area:RestoreNoOpThe PackageReference no-opThe PackageReference no-opCategory:Quality WeekIssues that should be considered for quality weekIssues that should be considered for quality weekFunctionality:RestorePriority:1High priority issues that must be resolved in the current sprint.High priority issues that must be resolved in the current sprint.RegressionFromPreviousRTMA regression from the last RTM. Example: worked in 6.2, doesn't work in 6.3A regression from the last RTM. Example: worked in 6.2, doesn't work in 6.3Type:Bug
Metadata
Metadata
Assignees
Labels
Area:RestoreNoOpThe PackageReference no-opThe PackageReference no-opCategory:Quality WeekIssues that should be considered for quality weekIssues that should be considered for quality weekFunctionality:RestorePriority:1High priority issues that must be resolved in the current sprint.High priority issues that must be resolved in the current sprint.RegressionFromPreviousRTMA regression from the last RTM. Example: worked in 6.2, doesn't work in 6.3A regression from the last RTM. Example: worked in 6.2, doesn't work in 6.3Type:Bug
Type
Fields
Give feedbackNo fields configured for issues without a type.
In NuGet/NuGet.Client#7246, I realized Test-NetCoreVSandMSBuildNoOp, which is the main way we check for no-op equivalency in VS vs CLI is not running.
It was disabled in because of #13003 in NuGet/NuGet.Client#5469 but we never enabled it back.
That was
Nov 10, 2023.Unfortunately there's been many changes in this space, including a new algorithm that have basically broken this test.
This has a massive impact, since a huge number of projects have CPM enabled and everyone .NET and above has pruning data.
Some of the changes that may have regressed it:
Related: #11231