Conversation
Contributor
Author
nkolev92
reviewed
Feb 29, 2024
Member
nkolev92
left a comment
There was a problem hiding this comment.
How do the numbers look like before/after the change?
How much of a difference is this making?
jeffkl
reviewed
Feb 29, 2024
ee6861a to
05a55b0
Compare
jeffkl
reviewed
Mar 1, 2024
nkolev92
previously approved these changes
Mar 4, 2024
Member
nkolev92
left a comment
There was a problem hiding this comment.
Let's add the env var just in case and 🚢 it.
nkolev92
approved these changes
Mar 4, 2024
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13214
Regression? Last working version:
Description
Switch calculating dependency graph spec json to a 64-bit non-crypto hash from SHA512 hash to reduce comparison/restore time but maintaining accuracy of need to restore when determining if NuGet needs to regenerate the dgspec.json file.
We've also added an escape hatch a user can set the environment variable
NUGET_ENABLE_LEGACY_DGSPEC_HASH_FUNCTIONtotrueto bring back the SHA512 hash function.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation