Skip to content

fix: recognize markdown MEDIA attachments#33269

Closed
robgfl45 wants to merge 1 commit into
NousResearch:mainfrom
robgfl45:fix-media-md-attachments-drake
Closed

fix: recognize markdown MEDIA attachments#33269
robgfl45 wants to merge 1 commit into
NousResearch:mainfrom
robgfl45:fix-media-md-attachments-drake

Conversation

@robgfl45

Copy link
Copy Markdown

Summary\n- add .md/.markdown to MEDIA tag extraction for gateway responses\n- add regression coverage for markdown document MEDIA tags\n\n## Validation\n- python -m pytest tests/gateway/test_platform_base.py::TestExtractMedia -q\n- python -m py_compile gateway/platforms/base.py gateway/run.py

@robgfl45 robgfl45 force-pushed the fix-media-md-attachments-drake branch from f711a10 to 19efc36 Compare May 27, 2026 14:12
@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have labels May 27, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competes with ~8 open PRs for the same MEDIA markdown fix: #31561, #29374, #31822, #33206, #32535, #30192, #30193. See #31560 for the issue. Preferred approach per prior triage is #29609 (dynamic derivation from SUPPORTED_DOCUMENT_TYPES).

@teknium1

Copy link
Copy Markdown
Contributor

Superseded by #34844, which consolidates this cluster.

This PR widens the extract_media extension allowlist, which is the right direction — but on its own it leaves the unconditional MEDIA:\s*\S+ strip in place, so a MEDIA: tag with any extension still outside the (now wider) list keeps getting deleted from the body before extract_local_files can pick up the bare path. #34844 fixes both halves: it unifies the two extractors onto a single shared extension set (MEDIA_DELIVERY_EXTS) AND replaces the loose strip with an extension-anchored one, so an unknown-extension path survives in the text instead of vanishing.

Closing as superseded — thanks for surfacing and helping pin down this bug; it was part of getting the full fix right. See #34844.

@teknium1 teknium1 closed this May 29, 2026
@robgfl45

robgfl45 commented May 29, 2026 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants