fix(gateway): recognize markdown files in MEDIA tags#29374
Closed
Rocky-Y008 wants to merge 1 commit into
Closed
Conversation
Collaborator
This was referenced May 21, 2026
Contributor
|
Superseded by #34844, which consolidates this cluster. This PR widens the Closing as superseded — thanks for surfacing and helping pin down this bug; it was part of getting the full fix right. See #34844. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mdto theMEDIA:attachment extension allowlist.Why this matters
Today,
MEDIA:/path/to/report.mdis not recognized by theMEDIA:parser even though Hermes documentsMEDIA:as supporting local files and the gateway document path can upload markdown throughsend_document().Without this fix, a generated markdown report is sent as literal text like:
For users, that is awkward: the artifact exists locally, but it does not arrive as a downloadable file. The practical workaround is to manually package the markdown into a
.zipbecause.zipis already in the allowlist. That adds friction for a common agent workflow: generate a report as markdown and send it back through a messaging gateway.This keeps
.mdbehavior consistent with other document extensions already supported byMEDIA:such as.txt,.pdf,.docx, and.zip.Test Plan
python -m pytest tests/gateway/test_base_media_document_extensions.py -q -o 'addopts='git diff --check