fix(gateway): restore .md extension to MEDIA extraction allowlist#30192
Closed
Kailigithub wants to merge 1 commit into
Closed
fix(gateway): restore .md extension to MEDIA extraction allowlist#30192Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
19 tasks
Collaborator
This was referenced May 26, 2026
Contributor
|
Superseded by #34844, which consolidates this cluster. This PR widens the Closing as superseded — thanks for surfacing and helping pin down this bug; it was part of getting the full fix right. See #34844. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit ea49b38 ("tighten MEDIA extraction regex + silent skip on file-not-found") replaced the permissive
MEDIA:\\S+regex with an explicit extension allowlist in three places. The.md(Markdown) extension was inadvertently omitted from that allowlist.Changes
gateway/platforms/base.py—extract_media(): addmdto the extension alternationgateway/run.py—_TOOL_MEDIA_RE(×2): addmdto the extension alternationAll three patterns now include
|mdalongside|txt|csv|apk|ipa.Verification
python3 -m py_compilepasses on both modified filesTestExtractMediatests pass (including a new regression test added for this fix)Closes #30186