fix(kanban-dashboard): wire onValueChange on OrchestrationPanel Selects#27893
Merged
Conversation
Contributor
🔎 Lint report:
|
Collaborator
|
Board James triage pass: the failing |
The dashboard SDK's <Select> is a shadcn-style popup that fires
onValueChange(value), not native onChange({target:{value}}). The file
even has a selectChangeHandler() helper at L213 documenting this:
"Older plugin code calls onChange({target:{value}}) which silently
never fires."
#24547 already fixed the bulk-reassign, workspace-kind, and new-task
parent selects. This patch covers the two OrchestrationPanel selects
introduced later in #27572 that regressed onto the same broken pattern:
- OrchestrationPanel orchestrator_profile picker
- OrchestrationPanel default_assignee picker
Users opened the popup, picked an option, and the popup closed without
firing a PUT to /orchestration — so the orchestrator profile and
default assignee dropdowns appeared totally inert.
Uses the same selectChangeHandler helper as the other working Selects
in the file for consistency.
Reported by Exaario.
de14942 to
472a15c
Compare
Lillard01
pushed a commit
to Lillard01/hermes-agent
that referenced
this pull request
May 21, 2026
…ts (NousResearch#27893) The dashboard SDK's <Select> is a shadcn-style popup that fires onValueChange(value), not native onChange({target:{value}}). The file even has a selectChangeHandler() helper at L213 documenting this: "Older plugin code calls onChange({target:{value}}) which silently never fires." NousResearch#24547 already fixed the bulk-reassign, workspace-kind, and new-task parent selects. This patch covers the two OrchestrationPanel selects introduced later in NousResearch#27572 that regressed onto the same broken pattern: - OrchestrationPanel orchestrator_profile picker - OrchestrationPanel default_assignee picker Users opened the popup, picked an option, and the popup closed without firing a PUT to /orchestration — so the orchestrator profile and default assignee dropdowns appeared totally inert. Uses the same selectChangeHandler helper as the other working Selects in the file for consistency. Reported by Exaario.
Mucky010
pushed a commit
to Mucky010/hermes-agent
that referenced
this pull request
May 24, 2026
…ts (NousResearch#27893) The dashboard SDK's <Select> is a shadcn-style popup that fires onValueChange(value), not native onChange({target:{value}}). The file even has a selectChangeHandler() helper at L213 documenting this: "Older plugin code calls onChange({target:{value}}) which silently never fires." NousResearch#24547 already fixed the bulk-reassign, workspace-kind, and new-task parent selects. This patch covers the two OrchestrationPanel selects introduced later in NousResearch#27572 that regressed onto the same broken pattern: - OrchestrationPanel orchestrator_profile picker - OrchestrationPanel default_assignee picker Users opened the popup, picked an option, and the popup closed without firing a PUT to /orchestration — so the orchestrator profile and default assignee dropdowns appeared totally inert. Uses the same selectChangeHandler helper as the other working Selects in the file for consistency. Reported by Exaario.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…ts (NousResearch#27893) The dashboard SDK's <Select> is a shadcn-style popup that fires onValueChange(value), not native onChange({target:{value}}). The file even has a selectChangeHandler() helper at L213 documenting this: "Older plugin code calls onChange({target:{value}}) which silently never fires." NousResearch#24547 already fixed the bulk-reassign, workspace-kind, and new-task parent selects. This patch covers the two OrchestrationPanel selects introduced later in NousResearch#27572 that regressed onto the same broken pattern: - OrchestrationPanel orchestrator_profile picker - OrchestrationPanel default_assignee picker Users opened the popup, picked an option, and the popup closed without firing a PUT to /orchestration — so the orchestrator profile and default assignee dropdowns appeared totally inert. Uses the same selectChangeHandler helper as the other working Selects in the file for consistency. Reported by Exaario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The orchestrator profile and default assignee dropdowns in the kanban dashboard Orchestration panel did nothing on change — popup opened, user picked an option, popup closed, nothing saved. This fixes both.
Root cause
The dashboard SDK's
<Select>is a shadcn-style popup that firesonValueChange(value), not nativeonChange({target:{value}}).plugins/kanban/dashboard/dist/index.jshas aselectChangeHandler()helper at L213 with this comment:#24547 already fixed three regressions onto the broken pattern (bulk-reassign / workspace-kind / new-task parent). The two OrchestrationPanel selects introduced later in #27572 regressed onto the same pattern and were missed.
Changes
plugins/kanban/dashboard/dist/index.js(2 sites, 8+/12-):orchestrator_profilepickerdefault_assigneepickerBoth rewired through the existing
selectChangeHandlerhelper for consistency with the other working Selects in the same file.Validation
node --checkpasses. BackendPUT /orchestrationwas already correct — it just wasn't being called.PUT /orchestrationfires, config.yaml updated, resolved label re-rendersReported by Exaario on Discord.