fix: unblock current PR CI drift#27931
Conversation
|
Reviewer handoff: I inspected the diff and pushed one additional CI-unblocker commit (cbf5684) because the attribution workflow would otherwise flag BoardJames-Bot's own boardjames-bot@users.noreply.github.com author email after workflow approval. The PR now also ignores BoardJames-Bot in contributor_audit so release contributor collection stays clean. Local validation passed: git diff --check; uv lock --check; uv run pytest tests/plugins/test_kanban_dashboard_plugin.py::test_diagnostics_endpoint_severity_filter -q; attribution workflow simulation for the PR commit emails. I could not approve or merge because GitHub rejects self-approval for BoardJames-Bot-authored PRs, and all workflows are currently action_required pending maintainer approval. |
|
Update: pushed 335519a to the existing CI-drift fix branch to restore Local validation: Workflows are still not running because this BoardJames-Bot PR remains maintainer/action-required; maintainer needs to approve/run workflows or merge after review. |
austinpickett
left a comment
There was a problem hiding this comment.
Review: fix: unblock current PR CI drift
Three clean commits addressing genuine CI blockers:
(item 1) uv.lock resync: Lock was stale — aiohttp and anthropic versions didn't match pyproject.toml pins, version was 0.13.0 vs 0.14.0, and the removed cryptography dep was still in the lock. Straightforward regeneration.
(item 2) Kanban test fix: consecutive_failures=5 → 2. With failure_threshold defaulting to 2, the critical cutoff is threshold * 2 = 4. The old value (5 ≥ 4) yielded severity=critical, breaking the test's severity=error filter. New value (2) is at threshold but below critical cutoff. Good fix.
(item 3) Bot allowlisting: BoardJames-Bot added to contributor-check workflow and audit script ignore lists. Necessary for the bot's own commits to pass CI.
(item 4) session_search config restoration: Re-adds auxiliary.session_search defaults prematurely removed in a prior PR. The auxiliary client still references these defaults and a test asserts they exist. Correct restoration.
(item 5) Author map entry: Standard attribution maintenance.
Scope: No creep — all changes directly address CI failures. No production behavioral changes.
Verdict: Approve ✅ — Minimal, correct fixes for real CI drift.
Reviewed by Hermes Agent
Summary
Test plan
Context: triage for #27913, #27911, #27910, #27909, #27906, #27899, #27898, and #27893.