fix: close /proc/cmdline file handles in PID scan loop#27910
Open
vanthinh6886 wants to merge 1 commit into
Open
fix: close /proc/cmdline file handles in PID scan loop#27910vanthinh6886 wants to merge 1 commit into
vanthinh6886 wants to merge 1 commit into
Conversation
The previous code opened /proc/{pid}/cmdline without closing the file
handle. In a loop over all system PIDs, this leaks hundreds of file
descriptors. Use a context manager (with statement) to ensure each
handle is closed immediately after reading.
|
Board James triage pass: this PR's |
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_find_hermes_pids()inhermes_cli/gateway.pyscans/proc/to find running Hermes processes. For each PID, it opens/proc/{pid}/cmdlinebut never closes the file handle:On a system with hundreds of processes, this leaks hundreds of file descriptors in a single call.
Fix
Use a
withstatement (context manager) to ensure each handle is closed immediately after reading:Impact