fix(kanban): workspace/parent/bulk-reassign selects revert to default (selectChangeHandler) by wesleysimplicio · Pull Request #24547 · NousResearch/hermes-agent

wesleysimplicio · 2026-05-12T21:20:02Z

Problem

In the Kanban dashboard's InlineCreate form, selecting worktree or dir in the workspace dropdown (and selecting a parent task or bulk-reassigning) silently reverts to the default value. Backend always receives workspace_kind: \"scratch\" regardless of user choice.

Root cause

The SDK's Select component (from window.__HERMES_PLUGIN_SDK__.components) fires onValueChange(rawValue) — not a DOM onChange event. Three selects in the plugin used the broken pattern:

// BROKEN — e is the raw value string; e.target is undefined
onChange: function (e) { setWorkspaceKind(e.target.value); }

e.target is undefined, so the setter is never called and the state stays at its initial value ("scratch", "", "").

The plugin already has a selectChangeHandler(setter) helper (line ~212) that wires both onValueChange and a guarded onChange for compatibility:

function selectChangeHandler(setter) {
  return {
    onValueChange: function (v) { setter(v == null ? "" : v); },
    onChange: function (e) {
      const v = e && e.target ? e.target.value : e;
      setter(v == null ? "" : v);
    },
  };
}

Fix

Replace all three bare h(Select, { onChange: ... }) calls with h(Select, Object.assign({...}, selectChangeHandler(setter))):

Location	Setter fixed
`BulkActionBar`	`setAssignee`
`InlineCreate` workspace	`setWorkspaceKind`
`InlineCreate` parent	`setParent`

No logic change — purely wiring the correct event hook.

Tests

Manually verified pattern against selectChangeHandler definition and all existing Object.assign(..., selectChangeHandler(...)) usages (board switcher, filter bar).
No JS tests exist for this plugin (plain IIFE, no build step).

Visual

sequenceDiagram
    participant User
    participant Select (SDK)
    participant Handler
    participant State

    Note over Select (SDK): fires onValueChange("worktree"), NOT onChange(event)

    rect rgb(255,80,80)
        Note over Handler,State: BEFORE — broken
        Select (SDK)->>Handler: onChange(e="worktree")
        Handler->>Handler: e.target → undefined → crash/noop
        State-->>State: stays "scratch"
    end

    rect rgb(80,200,80)
        Note over Handler,State: AFTER — fixed
        Select (SDK)->>Handler: onValueChange("worktree")
        Handler->>State: setWorkspaceKind("worktree")
        State-->>State: "worktree" ✓
    end

Closes #24520

…reassign selects SDK Select fires onValueChange(value) not onChange({target:{value}}), so all three bare onChange handlers silently received undefined from e.target. Replace raw onChange with selectChangeHandler() — the existing helper that wires both onValueChange and a guarded onChange — so selections register regardless of which event the SDK Select dispatches. Closes NousResearch#24520 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Copilot wasn't able to review any files in this pull request.

Copilot

Copilot wasn't able to review any files in this pull request.

The dashboard SDK's <Select> is a shadcn-style popup that fires onValueChange(value), not native onChange({target:{value}}). The file even has a selectChangeHandler() helper at L213 documenting this: "Older plugin code calls onChange({target:{value}}) which silently never fires." #24547 already fixed the bulk-reassign, workspace-kind, and new-task parent selects. This patch covers the two OrchestrationPanel selects introduced later in #27572 that regressed onto the same broken pattern: - OrchestrationPanel orchestrator_profile picker - OrchestrationPanel default_assignee picker Users opened the popup, picked an option, and the popup closed without firing a PUT to /orchestration — so the orchestrator profile and default assignee dropdowns appeared totally inert. Uses the same selectChangeHandler helper as the other working Selects in the file for consistency. Reported by Exaario.

…ts (#27893) The dashboard SDK's <Select> is a shadcn-style popup that fires onValueChange(value), not native onChange({target:{value}}). The file even has a selectChangeHandler() helper at L213 documenting this: "Older plugin code calls onChange({target:{value}}) which silently never fires." #24547 already fixed the bulk-reassign, workspace-kind, and new-task parent selects. This patch covers the two OrchestrationPanel selects introduced later in #27572 that regressed onto the same broken pattern: - OrchestrationPanel orchestrator_profile picker - OrchestrationPanel default_assignee picker Users opened the popup, picked an option, and the popup closed without firing a PUT to /orchestration — so the orchestrator profile and default assignee dropdowns appeared totally inert. Uses the same selectChangeHandler helper as the other working Selects in the file for consistency. Reported by Exaario.

…reassign selects (NousResearch#24547) SDK Select fires onValueChange(value) not onChange({target:{value}}), so all three bare onChange handlers silently received undefined from e.target. Replace raw onChange with selectChangeHandler() — the existing helper that wires both onValueChange and a guarded onChange — so selections register regardless of which event the SDK Select dispatches. Closes NousResearch#24520 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

…ts (NousResearch#27893) The dashboard SDK's <Select> is a shadcn-style popup that fires onValueChange(value), not native onChange({target:{value}}). The file even has a selectChangeHandler() helper at L213 documenting this: "Older plugin code calls onChange({target:{value}}) which silently never fires." NousResearch#24547 already fixed the bulk-reassign, workspace-kind, and new-task parent selects. This patch covers the two OrchestrationPanel selects introduced later in NousResearch#27572 that regressed onto the same broken pattern: - OrchestrationPanel orchestrator_profile picker - OrchestrationPanel default_assignee picker Users opened the popup, picked an option, and the popup closed without firing a PUT to /orchestration — so the orchestrator profile and default assignee dropdowns appeared totally inert. Uses the same selectChangeHandler helper as the other working Selects in the file for consistency. Reported by Exaario.

…reassign selects (NousResearch#24547) SDK Select fires onValueChange(value) not onChange({target:{value}}), so all three bare onChange handlers silently received undefined from e.target. Replace raw onChange with selectChangeHandler() — the existing helper that wires both onValueChange and a guarded onChange — so selections register regardless of which event the SDK Select dispatches. Closes NousResearch#24520 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

…ts (NousResearch#27893) The dashboard SDK's <Select> is a shadcn-style popup that fires onValueChange(value), not native onChange({target:{value}}). The file even has a selectChangeHandler() helper at L213 documenting this: "Older plugin code calls onChange({target:{value}}) which silently never fires." NousResearch#24547 already fixed the bulk-reassign, workspace-kind, and new-task parent selects. This patch covers the two OrchestrationPanel selects introduced later in NousResearch#27572 that regressed onto the same broken pattern: - OrchestrationPanel orchestrator_profile picker - OrchestrationPanel default_assignee picker Users opened the popup, picked an option, and the popup closed without firing a PUT to /orchestration — so the orchestrator profile and default assignee dropdowns appeared totally inert. Uses the same selectChangeHandler helper as the other working Selects in the file for consistency. Reported by Exaario.

Copilot AI review requested due to automatic review settings May 12, 2026 21:20

Copilot AI reviewed May 12, 2026

View reviewed changes

alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins labels May 12, 2026

alt-glitch mentioned this pull request May 18, 2026

fix(kanban-dashboard): wire onValueChange on OrchestrationPanel Selects #27893

Merged

austinpickett approved these changes May 18, 2026

View reviewed changes

austinpickett requested a review from Copilot May 18, 2026 11:43

Copilot AI reviewed May 18, 2026

View reviewed changes

austinpickett requested a review from Copilot May 18, 2026 14:47

Copilot AI reviewed May 18, 2026

View reviewed changes

austinpickett merged commit 16abb74 into NousResearch:main May 18, 2026
4 of 7 checks passed

maxmilian mentioned this pull request May 18, 2026

fix(kanban-dashboard): make Orchestration mode checkbox label static #28258

Closed

alt-glitch mentioned this pull request May 19, 2026

bug(kanban-dashboard): bulk-reassign Select uses onChange/e.target.value but SDK Select fires onValueChange(value) — Apply does nothing #28968

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(kanban): workspace/parent/bulk-reassign selects revert to default (selectChangeHandler)#24547

fix(kanban): workspace/parent/bulk-reassign selects revert to default (selectChangeHandler)#24547
austinpickett merged 1 commit into
NousResearch:mainfrom
wesleysimplicio:fix/cx06-issue-24520-kanban-select-onchange

wesleysimplicio commented May 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

wesleysimplicio commented May 12, 2026

Problem

Root cause

Fix

Tests

Visual

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants