fix(feishu): route send_message media attachments#14365
Open
qwertysc wants to merge 1 commit into
Open
Conversation
Collaborator
|
Also consider pulling in the MEDIA: tag parsing from #15299 — lets users embed media in message text like |
This was referenced Apr 28, 2026
|
Tested the same fix path locally in a Feishu DM: routing |
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_messageFeishu delivery through_send_feishu(..., media_files=...)when attachments are presentRoot cause
_send_feishu()already accepted and processedmedia_files, but_send_to_platform()sent Feishu through the generic non-media path and never passed attachments along. That causedMEDIA:attachments to be dropped for Feishu targets.Test plan
pytest -q tests/tools/test_send_message_tool.py -k "TestSendToPlatformFeishuMedia or TestSendToPlatformDiscordMedia::test_media_files_passed_on_last_chunk_only"pytest -q tests/gateway/test_feishu.py -k "send_image_file_uploads_image_and_sends_image_message or send_image_file_with_caption_uses_single_post_message"Fixes #10136