Skip to content

fix(tools): route Feishu media sends through native sender#8607

Open
yylronaldo wants to merge 1 commit into
NousResearch:mainfrom
yylronaldo:fix/feishu-media-routing
Open

fix(tools): route Feishu media sends through native sender#8607
yylronaldo wants to merge 1 commit into
NousResearch:mainfrom
yylronaldo:fix/feishu-media-routing

Conversation

@yylronaldo

@yylronaldo yylronaldo commented Apr 12, 2026

Copy link
Copy Markdown

Summary

  • route Feishu send_message media attachments through the native Feishu sender instead of the generic chunked text path
  • preserve existing text-only behavior while ensuring media delivery uses the platform-specific implementation
  • add regression coverage for Feishu media routing and cron duplicate-target handling

Testing

  • python -m pytest tests/tools/test_send_message_tool.py -q

This was referenced Apr 23, 2026
Open
Open
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists platform/feishu Feishu / Lark adapter comp/tools Tool registry, model_tools, toolsets duplicate This issue or pull request already exists labels Apr 28, 2026
@alt-glitch

alt-glitch commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Likely duplicate of #14365 — same root cause: _send_to_platform() routes Feishu through generic non-media path despite _send_feishu() supporting media_files. See also #10392, #14892, #14049 for the same fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/tools Tool registry, model_tools, toolsets duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists platform/feishu Feishu / Lark adapter type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yylronaldo @alt-glitch