Skip to content

fix: route media files to Feishu send_message pipeline#14049

Open
s6tiger wants to merge 1 commit into
NousResearch:mainfrom
s6tiger:main
Open

fix: route media files to Feishu send_message pipeline#14049
s6tiger wants to merge 1 commit into
NousResearch:mainfrom
s6tiger:main

Conversation

@s6tiger

@s6tiger s6tiger commented Apr 22, 2026

Copy link
Copy Markdown

Summary

Fixes #10136

Route media_files to _send_feishu() in the send_message tool pipeline. The Feishu adapter already fully supports file sending (send_document, send_image_file, send_video), but the routing layer silently dropped media_files for Feishu.

Changes

  • Added Feishu media routing branch in tools/send_message_tool.py before the non-media fallback
  • Passes media_files to _send_feishu() so MEDIA: tagged files are delivered correctly

Test

Tested by sending PPT and markdown files via Feishu DM — both delivered successfully.


Simple fix addressing the exact issue reported in #10136. The adapter layer (feishu.py) was already correct; only the routing layer was missing the Feishu branch.

_send_feishu already supports image/video/voice/document attachments,
but the upstream router dropped media_files into the non-media branch.
Add Feishu to the media routing section so MEDIA: tags work in
send_message for Feishu.
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/tools Tool registry, model_tools, toolsets platform/feishu Feishu / Lark adapter duplicate This issue or pull request already exists labels Apr 22, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #10392 — same fix: add Feishu to media routing branch in send_message_tool.py. Also overlaps with #6421 and #12461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tools Tool registry, model_tools, toolsets duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists platform/feishu Feishu / Lark adapter type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Feishu file sending broken: media_files parameter not passed to _send_feishu()

2 participants