Skip to content

feat(send_message): add Feishu image/media attachment support#15299

Closed
papperrollinggery wants to merge 1 commit into
NousResearch:mainfrom
papperrollinggery:feat/feishu-image-support
Closed

feat(send_message): add Feishu image/media attachment support#15299
papperrollinggery wants to merge 1 commit into
NousResearch:mainfrom
papperrollinggery:feat/feishu-image-support

Conversation

@papperrollinggery

Copy link
Copy Markdown

Summary

Fixes missing Feishu image attachment support in the send_message tool.

Changes

  • Bug fix: _send_feishu was never receiving media_files — they were always None (line 567 was missing the parameter)
  • New feature: Feishu now supports MEDIA:<path> tags in messages, just like Telegram/Discord/Matrix/Weixin/Signal
  • Added Feishu to the "media-only" permission list (error when sending only media without text)
  • Added Feishu to the "media omission warning" skip list

Root cause

The _send_feishu call at line 567 was missing media_files=media_files:

# Before (broken)
result = await _send_feishu(pconfig, chat_id, chunk, thread_id=thread_id)

# After (fixed)
result = await _send_feishu(pconfig, chat_id, chunk, media_files=media_files if is_last else [], thread_id=thread_id)

Testing

Verified with curl against the Feishu Open API — image upload and message sending work correctly.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists platform/feishu Feishu / Lark adapter labels Apr 24, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #14365 — same root cause: _send_to_platform() routes Feishu without passing media_files parameter. At least 5 competing PRs for this fix: #10392, #14049, #14892, #12461.

@papperrollinggery

Copy link
Copy Markdown
Author

Closing as duplicate of #14365 — same root cause, will跟进主修复线

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Medium — degraded but workaround exists platform/feishu Feishu / Lark adapter type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants