Skip to content

buildPython*: enable strictDeps#54182

Closed
FRidh wants to merge 1 commit intoNixOS:stagingfrom
FRidh:strictdeps
Closed

buildPython*: enable strictDeps#54182
FRidh wants to merge 1 commit intoNixOS:stagingfrom
FRidh:strictdeps

Conversation

@FRidh
Copy link
Copy Markdown
Member

@FRidh FRidh commented Jan 17, 2019

Motivation for this change

Continuation of #53445.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh added 6.topic: python Python is a high-level, general-purpose programming language. 2.status: work-in-progress 6.topic: cross-compilation Building packages on a different platform than they will be used on labels Jan 17, 2019
@FRidh FRidh mentioned this pull request Jan 17, 2019
12 tasks
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 17, 2019
@FRidh
Copy link
Copy Markdown
Member Author

FRidh commented Feb 14, 2019

Included in #55757

@dotlambda
Copy link
Copy Markdown
Member

@FRidh Can you please add a paragraph to the manual explaining nativeBuildInputs vs buildInputs for Python packages? I'm especially interested in cases such as pytestrunner.

@FRidh
Copy link
Copy Markdown
Member Author

FRidh commented Feb 15, 2019

Done, see 4bd168e

@dotlambda
Copy link
Copy Markdown
Member

Thanks a lot!

@FRidh
Copy link
Copy Markdown
Member Author

FRidh commented Feb 22, 2019

This feature ended up in staging-next so closing.

@FRidh FRidh closed this Feb 22, 2019
timokau added a commit to timokau/nixpkgs that referenced this pull request Mar 3, 2019
timokau added a commit to timokau/nixpkgs that referenced this pull request Mar 3, 2019
timokau added a commit to timokau/nixpkgs that referenced this pull request Mar 10, 2019
See NixOS#54182 and
NixOS#55757.

(cherry picked from commit 9e37547)
timokau added a commit to timokau/nixpkgs that referenced this pull request Mar 10, 2019
dotlambda pushed a commit that referenced this pull request Mar 15, 2019
fallout of #54182

(cherry picked from commit f704bee)
dotlambda pushed a commit that referenced this pull request Mar 15, 2019
dotlambda pushed a commit that referenced this pull request Mar 16, 2019
fallout of #54182

(cherry picked from commit f715658)
dotlambda pushed a commit that referenced this pull request Mar 18, 2019
fallout of #54182
fixes #57263

(cherry picked from commit ea7885f)
pull bot pushed a commit to milibopp/nixpkgs that referenced this pull request Mar 18, 2019
dotlambda pushed a commit to dotlambda/nixpkgs that referenced this pull request Mar 19, 2019
dotlambda pushed a commit that referenced this pull request Mar 21, 2019
fallout of #54182

(cherry picked from commit 06bcb5c)
dotlambda pushed a commit to dotlambda/nixpkgs that referenced this pull request Mar 21, 2019
dotlambda pushed a commit that referenced this pull request Mar 22, 2019
fallout of #54182

(cherry picked from commit 8519983)
dotlambda pushed a commit that referenced this pull request Mar 26, 2019
fallout of #54182

(cherry picked from commit 2413b2a)
dotlambda pushed a commit that referenced this pull request Mar 26, 2019
dotlambda pushed a commit to dotlambda/nixpkgs that referenced this pull request Mar 26, 2019
@dotlambda dotlambda mentioned this pull request Mar 26, 2019
10 tasks
dotlambda added a commit that referenced this pull request Mar 26, 2019
dotlambda added a commit that referenced this pull request Mar 26, 2019
fallout of #54182

(cherry picked from commit 29cec94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants