Skip to content

WIP: buildPython*: enable strictDeps#53445

Closed
FRidh wants to merge 1 commit intostagingfrom
python-unstable
Closed

WIP: buildPython*: enable strictDeps#53445
FRidh wants to merge 1 commit intostagingfrom
python-unstable

Conversation

@FRidh
Copy link
Copy Markdown
Member

@FRidh FRidh commented Jan 5, 2019 •
edited
Loading

Motivation for this change

Enable strictDeps to check whether we're using (native)BuildInputs correctly or not. Fixing the fall-out of enabling this would be a huge step forward for cross-compiling Python packages.

Python cross-compilation issue #53320

This PR includes a stdenv change for which a separate PR exists #53440. When that's accepted, the majority of changes will be ensuring the test dependencies are in the checkInputs.

To do:

  • document strictDeps is enabled and clarify the inputs situation regarding Python packages
  • changelog
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh added 6.topic: python Python is a high-level, general-purpose programming language. 1.severity: mass-rebuild labels Jan 5, 2019
@GrahamcOfBorg GrahamcOfBorg added 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 5, 2019
@FRidh FRidh force-pushed the python-unstable branch 2 times, most recently from 2358350 to 1617813 Compare January 5, 2019 14:16
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Jan 5, 2019

All in favor for that. This should be also mentioned in the release notes as it affects also user packages.

@FRidh FRidh changed the title buildPython*: enable strictDeps WIP: buildPython*: enable strictDeps Jan 5, 2019
@FRidh FRidh force-pushed the python-unstable branch 3 times, most recently from 59a0f73 to 694f44a Compare January 5, 2019 17:39
@FRidh FRidh mentioned this pull request Jan 6, 2019
Merged
10 tasks
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: stdenv Standard environment 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Jan 13, 2019
@FRidh FRidh mentioned this pull request Jan 15, 2019
Closed
10 tasks
@GrahamcOfBorg GrahamcOfBorg removed the 8.has: documentation This PR adds or changes documentation label Jan 15, 2019
@FRidh FRidh mentioned this pull request Jan 17, 2019
Closed
10 tasks
@FRidh
Copy link
Copy Markdown
Member Author

FRidh commented Jan 17, 2019

I need the python-unstable branch for something else so closing this now in favor of #54182.

@FRidh FRidh closed this Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FRidh @Mic92 @GrahamcOfBorg