Skip to content

python.pkgs.cartopy: fix build#58361

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:cartopy-fix
Mar 26, 2019
Merged

python.pkgs.cartopy: fix build#58361
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:cartopy-fix

Conversation

@dotlambda
Copy link
Copy Markdown
Member

@dotlambda dotlambda commented Mar 26, 2019

Motivation for this change

fallout of #54182

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @mredaelli

@dotlambda dotlambda requested a review from FRidh as a code owner March 26, 2019 12:38
@dotlambda dotlambda changed the title python.pkgs.cartopy: fix build: python.pkgs.cartopy: fix build Mar 26, 2019
@dotlambda dotlambda mentioned this pull request Mar 26, 2019
Merged
@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 26, 2019
@GrahamcOfBorg GrahamcOfBorg added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 26, 2019
@dotlambda dotlambda merged commit 29cec94 into NixOS:master Mar 26, 2019
@dotlambda dotlambda deleted the cartopy-fix branch March 26, 2019 15:49
dotlambda added a commit that referenced this pull request Mar 26, 2019
@dotlambda
python.pkgs.cartopy: fix build (#58361)
409b46d 
fallout of #54182

(cherry picked from commit 29cec94)
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@FRidh FRidh FRidh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dotlambda @FRidh @samueldr @GrahamcOfBorg