ocis: apply patch to fix broken kopano tarball, migrate to fetcherVersion = 3#513204
Merged
Conversation
…sion = 3 The upstream tarball at https://download.kopano.io/community/kapp:/kpop-2.2.0.tgz is no longer available. Adapted from the upstream fix in v8.0.1 (owncloud/ocis#12043).
15 tasks
qweered
added a commit
to qweered/nixpkgs
that referenced
this pull request
Apr 24, 2026
fetcherVersion = 1 was kept around for backwards compatibility while callers migrated to 2/3. Most of them have; the remainder are being cleared in NixOS#494402 and NixOS#513204. Emit a `lib.warnIf` warning pointing at the affected pname whenever v1 is used, gated by `lib.oldestSupportedReleaseIsAtLeast 2611` so the deprecation message only becomes visible once 26.11 is the oldest supported release (i.e., the next LTS to EOL). At that point, `supportedFetcherVersions` should drop 1 and the dead v1 code paths in default.nix, pnpm-config-hook.sh and serve.nix can be cleaned up. Also rewrite the manual section to recommend fetcherVersion = 3 for new packages and mark v1 as deprecated/scheduled-for-removal in the version history.
qweered
added a commit
to qweered/nixpkgs
that referenced
this pull request
Apr 24, 2026
fetcherVersion = 1 was kept around for backwards compatibility while callers migrated to 2/3. Most of them have; the remainder are being cleared in NixOS#494402 and NixOS#513204. Emit a `lib.warnIf` warning pointing at the affected pname whenever v1 is used, gated by `lib.oldestSupportedReleaseIsAtLeast 2605` so the deprecation message activates once 26.05 becomes the oldest supported release (~Jun 2026, when 25.11 EOLs). That gives users roughly one release cycle of advance notice before v1 is removed in 26.11. After 26.11 ships, a follow-up PR should drop 1 from `supportedFetcherVersions` and clean up the dead v1 code paths in default.nix, pnpm-config-hook.sh and serve.nix. Also rewrite the manual section to recommend fetcherVersion = 3 for new packages and mark v1 as deprecated/scheduled-for-removal in the version history.
2 tasks
qweered
added a commit
to qweered/nixpkgs
that referenced
this pull request
Apr 24, 2026
fetcherVersion = 1 was kept around for backwards compatibility while callers migrated to 2/3. Most of them have; the remainder are being cleared in NixOS#494402 and NixOS#513204. Emit a `lib.warnIf` warning pointing at the affected pname whenever v1 is used, gated by `lib.oldestSupportedReleaseIsAtLeast 2605` so the deprecation message activates once 26.05 becomes the oldest supported release (~Jun 2026, when 25.11 EOLs). That gives users roughly one release cycle of advance notice before v1 is removed in 26.11. After 26.11 ships, a follow-up PR should drop 1 from `supportedFetcherVersions` and clean up the dead v1 code paths in default.nix, pnpm-config-hook.sh and serve.nix. Also rewrite the manual section to recommend fetcherVersion = 3 for new packages and mark v1 as deprecated/scheduled-for-removal in the version history.
Scrumplex
previously approved these changes
Apr 25, 2026
Scrumplex
pushed a commit
to qweered/nixpkgs
that referenced
this pull request
Apr 26, 2026
fetcherVersion = 1 was kept around for backwards compatibility while callers migrated to 2/3. Most of them have; the remainder are being cleared in NixOS#494402 and NixOS#513204. Emit a `lib.warnIf` warning pointing at the affected pname whenever v1 is used. After 26.11 ships, a follow-up PR should drop 1 from `supportedFetcherVersions` and clean up the dead v1 code paths in default.nix, pnpm-config-hook.sh and serve.nix. Also rewrite the manual section to recommend fetcherVersion = 3 for new packages and mark v1 as deprecated/scheduled-for-removal in the version history. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
pushed a commit
to qweered/nixpkgs
that referenced
this pull request
Apr 26, 2026
fetcherVersion = 1 was kept around for backwards compatibility while callers migrated to 2/3. Most of them have; the remainder are being cleared in NixOS#494402 and NixOS#513204. Emit a `lib.warnIf` warning pointing at the affected pname whenever v1 is used. After 26.11 ships, a follow-up PR should drop 1 from `supportedFetcherVersions` and clean up the dead v1 code paths in default.nix, pnpm-config-hook.sh and serve.nix. Also rewrite the manual section to recommend fetcherVersion = 3 for new packages and mark v1 as deprecated/scheduled-for-removal in the version history. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Member
|
Replying to @qweered in #513215 (comment)
As this patch changes the behavior of the application slightly, I wasn't quite confident in merging this without approval from the maintainer. Alternatively, we can mark this package as broken in #513215 to expedite the merge over there and fix this up later. |
Contributor
Author
|
I mean it only affects login page and I tested login works, also there is pull request that updates ocis to new version #384343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kpopdependency fromservices/idp, whose upstream tarball (https://download.kopano.io/community/kapp:/kpop-2.2.0.tgz) is no longer served by kopano.io. The patch is adapted from the upstream fix (owncloud/ocis#12043, first released in v8.0.1) since oCIS is pinned to 5.0.9 in nixpkgs and the upstream diff doesn't apply to that version.pnpmDepsfromfetcherVersion = 1tofetcherVersion = 3with a freshly computed hash.With this change, the last package in nixpkgs using
fetcherVersion = 1is migrated (after #494402 lands). Fresh builds ofocis.pnpmDepsno longer hit the dead kopano URL.The patch removes
kpopfromservices/idp/package.jsonandpnpm-lock.yaml, and replaces the kpop theme import inservices/idp/src/App.jsxwith@material-ui/core/styles' stockcreateTheme(). The IDP sign-in page therefore renders with a default Material-UI v4 theme instead of the Kopano-branded one (functional but unstyled by the old CSS resets).Things done
passthru.tests.