Skip to content

chore(idp): use kpop without dependency#12043

Merged
LukasHirt merged 1 commit into
masterfrom
chore/use-kpop-without-dependency
Feb 20, 2026
Merged

chore(idp): use kpop without dependency#12043
LukasHirt merged 1 commit into
masterfrom
chore/use-kpop-without-dependency

Conversation

@LukasHirt

Copy link
Copy Markdown
Contributor

Description

Instead of trying to download kpop every time, bring in the specific code that we are using. There is very little code that we are actually using from kpop so pulling it as a dependency is not really necessary and it should fix the current CI issues.

Motivation and Context

One less dependency and hopefully green CI.

How Has This Been Tested?

  • test environment: 🤖

@LukasHirt LukasHirt self-assigned this Feb 20, 2026
@update-docs

This comment was marked as off-topic.

Instead of trying to download kpop every time, bring in the specific
code that we are using. There is very little code that we are actually
using from kpop so pulling it as a dependency is not really necessary
and it should fix the current CI issues.
@LukasHirt LukasHirt force-pushed the chore/use-kpop-without-dependency branch from 116bb00 to bc78197 Compare February 20, 2026 09:30
@sonarqubecloud

Copy link
Copy Markdown

@LukasHirt LukasHirt merged commit 0d690c4 into master Feb 20, 2026
5 checks passed
@LukasHirt LukasHirt deleted the chore/use-kpop-without-dependency branch February 20, 2026 10:10
ownclouders pushed a commit that referenced this pull request Feb 20, 2026
…ency

chore(idp): use kpop without dependency
ownclouders pushed a commit that referenced this pull request Feb 21, 2026
…ency

chore(idp): use kpop without dependency
@mmattel

mmattel commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

Why no changelog?

@LukasHirt

Copy link
Copy Markdown
Contributor Author

This is a technical topic. It is a fix for CI but in no way changes any user functionality. We do changelog only for user facing changes. Same applies e.g. to dependencies where when bumping them we also omit changelog.

ownclouders pushed a commit that referenced this pull request Feb 22, 2026
…ency

chore(idp): use kpop without dependency
ownclouders pushed a commit that referenced this pull request Feb 23, 2026
…ency

chore(idp): use kpop without dependency
ownclouders pushed a commit that referenced this pull request Feb 23, 2026
…ency

chore(idp): use kpop without dependency
@donmor donmor mentioned this pull request Feb 24, 2026
@mklos-kw mklos-kw restored the chore/use-kpop-without-dependency branch February 24, 2026 09:10
@nirajacharya2 nirajacharya2 deleted the chore/use-kpop-without-dependency branch March 11, 2026 06:42
pull Bot pushed a commit to imide/nixpkgs that referenced this pull request Apr 26, 2026
…sion = 3

The upstream tarball at https://download.kopano.io/community/kapp:/kpop-2.2.0.tgz
is no longer available. Adapted from the upstream fix in v8.0.1
(owncloud/ocis#12043).
llakala pushed a commit to llakala/nixpkgs that referenced this pull request Apr 26, 2026
…sion = 3

The upstream tarball at https://download.kopano.io/community/kapp:/kpop-2.2.0.tgz
is no longer available. Adapted from the upstream fix in v8.0.1
(owncloud/ocis#12043).
RemuSalminen pushed a commit to RemuSalminen/nixpkgs that referenced this pull request Apr 26, 2026
…sion = 3

The upstream tarball at https://download.kopano.io/community/kapp:/kpop-2.2.0.tgz
is no longer available. Adapted from the upstream fix in v8.0.1
(owncloud/ocis#12043).
salva09 pushed a commit to salva09/nixpkgs that referenced this pull request May 7, 2026
…sion = 3

The upstream tarball at https://download.kopano.io/community/kapp:/kpop-2.2.0.tgz
is no longer available. Adapted from the upstream fix in v8.0.1
(owncloud/ocis#12043).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants