Skip to content

ocis: 5.0.9 -> 7.0.1#384343

Draft
liberodark wants to merge 1 commit into
NixOS:masterfrom
liberodark:ocis
Draft

ocis: 5.0.9 -> 7.0.1#384343
liberodark wants to merge 1 commit into
NixOS:masterfrom
liberodark:ocis

Conversation

@liberodark

@liberodark liberodark commented Feb 22, 2025

Copy link
Copy Markdown
Contributor

Fix : #384319
Diff : owncloud/ocis@v5.0.9...v7.0.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 22, 2025
@nix-owners nix-owners Bot requested a review from xinyangli February 22, 2025 21:05
@xinyangli

xinyangli commented Feb 23, 2025

Copy link
Copy Markdown
Member

Thanks for your help! But we might have more to consider for this upgrade:

  1. The version of ocis.web also requires an update. Specifically, for version 7.0.1, it should be updated to 11.0.7.
  2. Running ocis init and ocis server after build does not work currently, as the page at 127.0.0.1:9200 gives a 404 error. Possibly due to the outdated frontend package.
  3. I noticed that the 6.0.0 release notes mention that a clean slate is required for migration. Given this, we might want to consider creating a separate package, ocis_7, as this seems like a backward-incompatible upgrade.
  4. Maybe we should consider upgrading ocis-bin at the same time. It would be weird if ocis-bin and ocis have different major version.

@Lab-8916100448256

Copy link
Copy Markdown

3. I noticed that the 6.0.0 release notes mention that a clean slate is required for migration. Given this, we might want to consider creating a separate package, ocis_7, as this seems like a backward-incompatible upgrade.

This seems to apply only to the 6.x rolling releases. There is a document describing how to upgrade from 5.x to 7.0.0 production release : https://doc.owncloud.com/ocis/next/migration/upgrading_5.0.x_7.0.0.html

@xinyangli

Copy link
Copy Markdown
Member

@Lab-8916100448256 Thanks for the heads-up! Since #394598 has been merged, we should first rename ocis to ocis_5 to align with the binary package, and then create a new ocis_7 package. I'll review and test this PR as soon as possible.

We'll also need to implement the NixOS module changes discussed in #388222, but that can be addressed in a separate PR.

@liberodark liberodark marked this pull request as draft May 5, 2025 09:01
@Ramblurr

Ramblurr commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Just a heads up, you will need ocis_5, ocis_70, and ocis_71. That's what we are doing for the ocis bin version of the package, see the maintainers section of the docs I've created.

We'll also need to implement the NixOS module changes discussed in #388222, but that can be addressed in a separate PR.

The nixos module changes are handled in my PR as well. Reviews on my PR welcome, it's been sitting awhile with no exposure :)

@Ramblurr

Ramblurr commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Also FWIW we renamed ocis-bin to ocis_5-bin in #394598 , so you could take the same steps and rename the ocis package to ocis_5.

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 16, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Request: ocis 5.0.9 → 7.0.1

4 participants