ocis_5-bin: rename from ocis-bin#394598
Merged
Merged
Conversation
Contributor
Author
|
@bhankas @danth This PR does not update any versions. It renames ocis-bin to ocis-bin5 and updates the nixos module. In my next PR I will add ocis-bin70 and ocis-bin71, and update the nixos module to choose correctly based on state version. This is all working very well, I am already running ocis 7.1 with on a couple nixos servers. The upgrade process is manual, but works smoothly. |
ffe9fe8 to
2500611
Compare
Jappie3
reviewed
Mar 30, 2025
3e8f3f2 to
f791170
Compare
NickCao
reviewed
Mar 31, 2025
NickCao
left a comment
Member
There was a problem hiding this comment.
Per nixpkgs conventions, ocis_5-bin might be more appropriate?
And we are getting ready for ocis-bin7 to land, where we will need to compare it to the system.stateVersion.
f791170 to
2db9547
Compare
Contributor
Author
Done! |
Contributor
Author
Jappie3
approved these changes
Apr 2, 2025
NickCao
approved these changes
Apr 2, 2025
Member
|
@ofborg test ocis |
Member
|
Oh it's unfree, tested |
This was referenced May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.