Skip to content

ocis-bin: 5.0.5 -> 7.1.0#388222

Closed
Ramblurr wants to merge 2 commits into
NixOS:masterfrom
Ramblurr:fix/ocis-update-script
Closed

ocis-bin: 5.0.5 -> 7.1.0#388222
Ramblurr wants to merge 2 commits into
NixOS:masterfrom
Ramblurr:fix/ocis-update-script

Conversation

@Ramblurr

@Ramblurr Ramblurr commented Mar 8, 2025

Copy link
Copy Markdown
Contributor
  • ocis-bin: fix updateScript
  • ocis-bin: 5.0.5 -> 7.1.0

Do not merge! This is a draft while the maintainers discuss how to handle possible breaking changes (see below).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 8, 2025
@Ramblurr

Ramblurr commented Mar 8, 2025

Copy link
Copy Markdown
Contributor Author

@danth @bhankas I fixed the update script, looks like it had broken because I added one to many #'s at the top 🐵 I fixed it, and added some print statements that will show up in the bot logs.

In any case we have a decision to make 7.1.0 is the new Production (aka stable) version. The list of changes for 5.x -> 7.x doesn't look wild, in fact there are no major breaking changes (caveat below)

However ocis comes with its own upgrade guide: https://doc.owncloud.com/ocis/next/migration/upgrading-ocis.html#version-5-0-x-to-7-0-0

Notably deprecated env vars have been removed, which people might be using.

This PR is marked as a draft, because we need to update the nixos module at the same time so that users on 5.x remain on 5.x until they are ready to move to 7.x.

I think we need to support multiple package versions, like the nextcloud or postgres pkgs:

Do you agree? If so I will update this PR so it provides the packages ocis-bin5 and ocis-bin7, and I will update the nixos module to remove the default package value of ocis-bin (users will have to explicitly choose a ocis-bin package)

@Ramblurr Ramblurr force-pushed the fix/ocis-update-script branch from 89eb86f to 57953ea Compare March 8, 2025 14:38
@github-actions github-actions Bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Mar 8, 2025
Ramblurr added 2 commits March 8, 2025 15:40
The updateScript was broken, now it works as expected.
@Ramblurr Ramblurr force-pushed the fix/ocis-update-script branch from 57953ea to ee4052b Compare March 8, 2025 14:41
@Ramblurr

Copy link
Copy Markdown
Contributor Author

@bhankas @danth I haven't heard back from ya'll yet. So I am going to go ahead and implement ocis-bin5 and ocis-bin7. Please let me know if you think we should go another direction.

@Ramblurr

Copy link
Copy Markdown
Contributor Author

PR for renaming ocis-bin to ocis-bin5 is here

#394598

@Ramblurr Ramblurr closed this Mar 30, 2025
@xinyangli xinyangli mentioned this pull request May 4, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant