Skip to content

botan2: drop#446190

Merged
7c6f434c merged 3 commits into
NixOS:masterfrom
71rd:botan2_remove
Oct 25, 2025
Merged

botan2: drop#446190
7c6f434c merged 3 commits into
NixOS:masterfrom
71rd:botan2_remove

Conversation

@71rd

@71rd 71rd commented Sep 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Final steps in deprecating and removing the botan2 library from nixpkgs.

The botan2 library has been EoL since 2025-01-01 and wont receive any more security updates.
All remaining dependants of botan2 have been updated or patches.

This PR marks the chicken scheme bindings for botan2 as broken, removes the botan2 package, and migrates botan3 to /pkgs/by-name

Resolves #445861

Things done

Mark the chicken scheme bindings for botan2 as broken and then remove the botan2 package.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@71rd 71rd mentioned this pull request Sep 25, 2025
Closed
5 tasks
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 26, 2025
@71rd 71rd force-pushed the botan2_remove branch 2 times, most recently from d2ecbd3 to f269755 Compare September 26, 2025 00:13
@71rd 71rd added 8.has: clean-up This PR removes packages or removes other cruft 6.topic: hygiene Cleaning up and removing cruft 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed labels Sep 26, 2025
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 26, 2025
@71rd 71rd added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 26, 2025
@nikstur

nikstur commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

When removing botan2 we should also convert botan to pkgs/by-name, naming it botan and making botan3 an alias for botan.

@71rd 71rd changed the title Botan2 remove botan2: drop Oct 20, 2025
@71rd 71rd force-pushed the botan2_remove branch 4 times, most recently from fe013a1 to 03b7355 Compare October 20, 2025 19:21
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Oct 20, 2025
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 20, 2025
@nikstur

nikstur commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Why is this targeting staging? There are no rebuilds so it shouldn't.

After retargeting, this is good to go from my end.

@thillux

thillux commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Was naming this package botan instead of botan3 not possible (as suggested by @nikstur)?

@nikstur

nikstur commented Oct 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Was naming this package botan instead of botan3 not possible (as suggested by @nikstur)?

It is already named botan because it is in pkgs/by-name/bo/botan. It is also aliased to botan3 (which IMO is the correct thing to do).

@thillux

thillux commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Marking botan instead of botan2 broken in Chicken is also correct?

@71rd

71rd commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

Marking botan instead of botan2 broken in Chicken is also correct?

yes, these appear to be general chicken bindings that were never upgraded for botan3

@7c6f434c

7c6f434c commented Oct 22, 2025

Copy link
Copy Markdown
Member

Agreed on targeting master (it's a 0-rebuild thing breaking only a package with bindings), and generally looks reasonable.

@71rd

71rd commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

Why is this targeting staging? There are no rebuilds so it shouldn't.
Yes i will retarget this PR as #446100 is now also in master

@71rd

71rd commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

Im not totally sure if renaming botan3 to botan is preferable, but i dont have a strong preference.
I would suggest maybe replacing all references to botan3 with botan in that case.

@7c6f434c

7c6f434c commented Oct 24, 2025

Copy link
Copy Markdown
Member

Honestly, I think they did some pretty unforced interface changes between Botan1 and Botan2 as well as between Botan2 and Botan3, including some stuff that kept compiling but failed at run time, so keeping the versioned naming makes senseto me here.

@nikstur

nikstur commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

so keeping the versioned naming makes senseto me here.

I don't have a strong opinion on this. Arch and Debian both call the 3.x package just botan so we would be in good company.

The biggest argument for me for keeping botan3 is to reduce the diff size.

In any case we should keep an alias around. Relying on the name botan3 shouldn't be a hard failure.

71rd added 3 commits October 24, 2025 14:52
@71rd
chickenPackages_5.chickenEggs.botan: mark broken
355a767 
Mark the chicken-scheme bindings for botan as broken.
The package only supports the botan2 library that has been deprecated
and is being removed
@71rd
botan2: remove
0a6777c 
Removing botan2 from nixpkgs.
Botan2 has been end-of-life since 2025-01-01 and was replaced with Botan3.

Fixes: NixOS#445861
@71rd
botan3: move to by-name
98a1608
@71rd 71rd changed the base branch from staging to master October 24, 2025 15:39
@nixpkgs-ci nixpkgs-ci Bot closed this Oct 24, 2025
@nixpkgs-ci nixpkgs-ci Bot reopened this Oct 24, 2025
@71rd

71rd commented Oct 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

thanks for your input.
then i will keepbotan3 instead of making it a deprecated alias and replacing every reference with botan, so we are better prepared for a potential botan4.

all other PR's related to #445861 appear to have reached master, so this PR has been retargeted and is hopefully now ready to be merged.

@71rd 71rd marked this pull request as ready for review October 24, 2025 15:55
@mdaniels5757 mdaniels5757 removed the 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed label Oct 25, 2025
mdaniels5757
mdaniels5757 approved these changes Oct 25, 2025
View reviewed changes

@mdaniels5757 mdaniels5757 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 25, 2025
@7c6f434c 7c6f434c added this pull request to the merge queue Oct 25, 2025
Merged via the queue into NixOS:master with commit f309a96 Oct 25, 2025
39 of 42 checks passed
@trofi

trofi commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

libxccStdenv is not a thing. Proposed minor eval fix as:

@WilliButz WilliButz mentioned this pull request Nov 3, 2025
Merged
13 tasks
@fabianhjr fabianhjr mentioned this pull request Dec 1, 2025
Merged
13 tasks
@71rd 71rd deleted the botan2_remove branch June 10, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@thillux thillux Awaiting requested review from thillux

@nikstur nikstur Awaiting requested review from nikstur

Assignees

No one assigned

Labels

6.topic: hygiene Cleaning up and removing cruft 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Request: Deprecate botan2

6 participants

@71rd @nikstur @thillux @7c6f434c @trofi @mdaniels5757