Skip to content

botan3: fix pkgsStatic eval#456385

Merged
7c6f434c merged 1 commit into
NixOS:masterfrom
trofi:botan3-fix-eval
Oct 28, 2025
Merged

botan3: fix pkgsStatic eval#456385
7c6f434c merged 1 commit into
NixOS:masterfrom
trofi:botan3-fix-eval

Conversation

@trofi

@trofi trofi commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

Without the change the eval fails as:

$ nix build --no-link -f. pkgsStatic.botan3
error:
   … while calling a functor (an attribute set with a '__functor' attribute)
     at lib/customisation.nix:317:7:
      316|     if missingArgs == { } then
      317|       makeOverridable f allArgs
         |       ^
      318|     # This needs to be an abort so it can't be caught with `builtins.tryEval`,

   … while evaluating a branch condition
     at lib/customisation.nix:182:7:
      181|       in
      182|       if isAttrs result then
         |       ^
      183|         result

   (stack trace truncated; use '--show-trace' to show the full, detailed trace)

   error: attribute 'libxccStdenv' missing
   at pkgs/by-name/bo/botan3/package.nix:37:28:
       36| let
       37|   stdenv' = if static then buildPackages.libxccStdenv else stdenv;
         |                            ^
       38| in

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Without the change the eval fails as:

    $ nix build --no-link -f. pkgsStatic.botan3
    error:
       … while calling a functor (an attribute set with a '__functor' attribute)
         at lib/customisation.nix:317:7:
          316|     if missingArgs == { } then
          317|       makeOverridable f allArgs
             |       ^
          318|     # This needs to be an abort so it can't be caught with `builtins.tryEval`,

       … while evaluating a branch condition
         at lib/customisation.nix:182:7:
          181|       in
          182|       if isAttrs result then
             |       ^
          183|         result

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: attribute 'libxccStdenv' missing
       at pkgs/by-name/bo/botan3/package.nix:37:28:
           36| let
           37|   stdenv' = if static then buildPackages.libxccStdenv else stdenv;
             |                            ^
           38| in
@trofi trofi changed the base branch from staging to master October 28, 2025 06:51
@nixpkgs-ci nixpkgs-ci Bot closed this Oct 28, 2025
@nixpkgs-ci nixpkgs-ci Bot reopened this Oct 28, 2025
@trofi trofi mentioned this pull request Oct 28, 2025
13 tasks
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 28, 2025
@nix-owners nix-owners Bot requested review from 7c6f434c, nikstur and thillux October 28, 2025 06:57
@trofi

trofi commented Oct 28, 2025

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 456385
Commit: 7583f8b836f4e5d6738033cda1c542587da3bc3a


x86_64-linux

✅ 1 package built:
  • nixpkgs-manual

@7c6f434c 7c6f434c added this pull request to the merge queue Oct 28, 2025
Merged via the queue into NixOS:master with commit f9661c0 Oct 28, 2025
35 of 41 checks passed
@trofi trofi deleted the botan3-fix-eval branch October 28, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants