botan2: fix build with gcc15#446100
Merged
Merged
Conversation
- add patch from fedora that adds `#include <cstdint.h>` to cli.h
Fixes build failure with gcc15:
```
In file included from src/cli/argon2.cpp:7:
src/cli/cli.h:125:71: error: 'uint8_t' does not name a type
125 | static std::string format_blob(const std::string& format, const uint8_t bits[], size_t len);
| ^~~~~~~
src/cli/cli.h:18:1: note: 'uint8_t' is defined in header '<cstdint>';
this is probably fixable by adding '#include <cstdint>'
17 | #include "cli_exceptions.h"
+++ |+#include <cstdint>
18 |
```
23b3647 to
ab31528
Compare
Contributor
|
Is this reported at the botan upstream? |
Contributor
Author
Sorry, found original fix in Either way it should be a "temporary solution" until |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#include <cstdint.h>to cli.hFixes build failure with gcc15:
Tested build with:
nix-build --expr 'with import ./. {}; botan2.override { stdenv = gcc15Stdenv; }'Part of fixes for gcc15 update:
#440456
Temporary solution in case:
#445861
is not solved before gcc15 update.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.