Skip to content

gnome2.gnome_vfs: remove#322862

Merged
jtojnar merged 5 commits intoNixOS:stagingfrom
jtojnar:no-gnome2-vfs
Jul 3, 2024
Merged

gnome2.gnome_vfs: remove#322862
jtojnar merged 5 commits intoNixOS:stagingfrom
jtojnar:no-gnome2-vfs

Conversation

@jtojnar
Copy link
Copy Markdown
Member

@jtojnar jtojnar commented Jun 27, 2024

Description of changes

Depends on: #322832, #322599, #322831, #324173
Part of #39976

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
    • verbiste-gtk
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jtojnar jtojnar mentioned this pull request Jun 27, 2024
13 tasks
@jtojnar
Copy link
Copy Markdown
Member Author

jtojnar commented Jun 27, 2024

Resolved and extracted the leaves to #322986

@SuperSandro2000
Copy link
Copy Markdown
Member

I think we can merge this when targeting staging.

@jtojnar jtojnar changed the base branch from master to staging July 2, 2024 22:36
@jtojnar jtojnar marked this pull request as ready for review July 2, 2024 22:37
@jtojnar jtojnar mentioned this pull request Jul 2, 2024
80 tasks
@jtojnar
Copy link
Copy Markdown
Member Author

jtojnar commented Jul 2, 2024

Ugh, looks like another dependent was introduced in the meanwhile: #278361

Opened #324173

@jtojnar jtojnar marked this pull request as draft July 2, 2024 22:56
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review July 3, 2024 11:30
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 3, 2024
@jtojnar jtojnar merged commit 9f3282e into NixOS:staging Jul 3, 2024
@jtojnar jtojnar deleted the no-gnome2-vfs branch July 3, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants