Skip to content

android-studio: remove gnome_vfs & GConf#322831

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
jtojnar:android-studio-gnome2-drop
Jun 28, 2024
Merged

android-studio: remove gnome_vfs & GConf#322831
JohnRTitor merged 1 commit intoNixOS:masterfrom
jtojnar:android-studio-gnome2-drop

Conversation

@jtojnar
Copy link
Copy Markdown
Member

@jtojnar jtojnar commented Jun 27, 2024

Description of changes

Those libraries have been deprecated for 10+ years and require daemons that no-one has running these days.

Continuation of #322599
Part of #39976

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Those libraries have been deprecated for 10+ years and require daemons
that no-one has running these days.
@@ -175,9 +175,7 @@ let

# For GTKLookAndFeel
gtk2
Copy link
Copy Markdown
Member Author

@jtojnar jtojnar Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really switch to GTK 3 but I will leave that to someone else.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gtk2 marked broken in my local config already 😅

@ofborg ofborg bot requested review from JohnRTitor, alapshin and numinit June 27, 2024 08:10
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 27, 2024
Copy link
Copy Markdown
Member

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, @jtojnar do you want to change it to gtk3 here or should I just merge it?

Ideally I would like this closer to jetbrains, android-studio is a defacto jetbrains product anyway.

@jtojnar
Copy link
Copy Markdown
Member Author

jtojnar commented Jun 27, 2024

GTK 3 will probably require more testing so best leaving it for a separate PR.

@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 27, 2024
@JohnRTitor JohnRTitor merged commit 3f8b731 into NixOS:master Jun 28, 2024
@jtojnar jtojnar deleted the android-studio-gnome2-drop branch June 28, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

Development

Successfully merging this pull request may close these issues.

5 participants