openjdk: remove gnome_vfs & GConf#322599
Conversation
Those libraries have been deprecated for 10+ years and require daemons that no-one has running these days. Keep the `enableGnome2` argument for BC.
|
The code looks good to me, as does the reasoning for removal, however my remaining concern is the fact that the flag now has different behavior, as it is no longer properly pulling in the GNOME 2 libraries when specified. This feels like the kind of thing that deserves a breaking change to completely rip out the GNOME 2 support if we are already partially removing it. That aside, considering the mass rebuild, this likely needs to be retargeted to staging as opposed to master. Please follow the instructions set out in CONTRIBUTING.md (and make sure you follow them. I've made this mistake twice already) if you do retarget. |
GNOME 2 dependencies were removed in the previous commit. gtk3 and glib are used to provide GTK look and feel. glib is also used for proxy settings but it probably does not make much sense to have a separate option, since disjoint union with GTK-based environments is small.
8b832cc to
0774766
Compare
|
Renamed the option. |
|
@ofborg build javaPackages.compiler.openjdk8 |
Description of changes
Those libraries have been deprecated for 10+ years and require daemons that no-one has running these days.
Keep the
enableGnome2argument for BC.Part of #39976
Replaces: #73407
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.