Skip to content

Remove some gnome2 dependents#322986

Merged
jtojnar merged 5 commits intoNixOS:masterfrom
jtojnar:gnome-vfs-dependents
Jul 2, 2024
Merged

Remove some gnome2 dependents#322986
jtojnar merged 5 commits intoNixOS:masterfrom
jtojnar:gnome-vfs-dependents

Conversation

@jtojnar
Copy link
Copy Markdown
Member

@jtojnar jtojnar commented Jun 27, 2024

Description of changes

Extracted from #322862

Part of #39976

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Jun 27, 2024
@ofborg ofborg bot requested a review from AndersonTorres June 27, 2024 19:51
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 27, 2024
@jtojnar jtojnar mentioned this pull request Jun 27, 2024
14 tasks
@jtojnar jtojnar requested review from chris-martin and viric June 28, 2024 10:34
jtojnar added 5 commits July 1, 2024 07:59
Not used by anything and deprecated for decades.
Hard depends on GNOME 2-era libgnomeui.
It has not been maintained in decades and is not used anyway since `configure.ac`
makes it conditional on WxWidgets using GTK 2 but we use GTK 3 now.

`configure.ac` has thumbnailing code path for GTK 3 that uses more modern
`gnome-desktop-3.0` but that is commented out.
No longer builds the GNOME 2 GUI by default but there is still GTK 2.
It has hard dependency on derelict libgnome.
@jtojnar jtojnar force-pushed the gnome-vfs-dependents branch from 16d2395 to 3c24501 Compare July 1, 2024 05:59
@ofborg ofborg bot requested a review from AndersonTorres July 1, 2024 06:41
Copy link
Copy Markdown
Contributor

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jtojnar jtojnar merged commit 7a2c8f9 into NixOS:master Jul 2, 2024
@jtojnar jtojnar deleted the gnome-vfs-dependents branch July 2, 2024 06:02
@jtojnar jtojnar mentioned this pull request Jul 2, 2024
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants