Conversation
|
|
||
| gradleProperties = '' | ||
| COMPILE_MEDIA = true | ||
| COMPILE_WEBKIT = false |
There was a problem hiding this comment.
Is there any chance to enable this? JabRef uses webkit and currently uses the lib from maven with a hack.
There was a problem hiding this comment.
I gave it a shot, but it's sort of tangled up with the mystery of the sha256-dV7/... hash a few lines above. Even if I enable this for the deps, the output hash doesn't change! So, the gradle build must be storing the things it fetches somewhere ad-hoc ... and so the main JavaFX build still tries & fails to fetch them. :-/
linking explicitly to #162064 as well, as there's some discussion of this issue there too. I'm afraid I don't have any more ideas on this front. :(
There was a problem hiding this comment.
I thought now I understand the problem. As a workground, is that possible to use https://github.com/openjdk/jfx/blob/master/WEBKIT-MEDIA-STUBS.md#officially-released-libraries?
There was a problem hiding this comment.
Hm ... I don't understand still! :) The page you linked to says these libraries are necessary for running tests. I don't understand how the decision of whether or not to run the tests impacts whether libjfxwebkit.so is produced by the build or not, though.
This definitely feels like a discussion that's better had over in #162064, though.
There was a problem hiding this comment.
I mean maybe it's possible to use the webkit files from the maven central directly?
Gradle has a task to automate downloading officially released libraries from MavenCentral.
Not sure if this can be used directly.
There was a problem hiding this comment.
This definitely feels like a discussion that's better had over in #162064, though.
Yes. Maybe I can have a try after this is merged.
6228901 to
7d81f31
Compare
|
Just pushed a new version that pins I've just updated my work machine to use this, including running Eclipse on 19; will report back in a few days on whether it's feeling stable or not. |
as usual this is mostly copy-pasted from 18, so this commit is best reviewed with '--find-copies-harder' stop exposing openjdk 18 since it was not a long-term support release change the default openjdk from 17 to 19 since nixpkgs is a rolling-release repository drop the ceremony around bootstrapping via adoptopenjdk for 64-bit builds vs. via earlier openjdk builds for 32-bit, because, to be frank, since we're using temurin now, it's not a simple copy-paste job. :-/ if someone needs a 32-bit openjdk, that work can be done separately. JavaFX revs from 17 to 19; it looks like 18 was never packaged along with JDK 18. * the gradle invocation used to build JavaFX must still be done with Java 18, as gradle does not yet support running itself on Java 19. * a couple of patches need to be applied, since a new State enum was introduced in the JDK that collides with one in JavaFX. * the hash of the gradle dependencies has not changed, which is surprising, but as far as I can tell correct. One application (libreoffice) doesn't work with 19 yet, so pin it to jdk 17 for now. Co-authored-by: Mario Rodas <marsam@users.noreply.github.com>
759f650 to
e7cfa26
Compare
|
This is feeling pretty stable to me after a week at work. |
There is currently a build issue with jdk19 (the new default from 17 after 2022-11-30; NixOS#199802)
|
Should this be backported? On 22.11, openjdk18 is marked as insecure as it has reached EOL while openjdk19 is not available. |
|
Noting that #232199 is the OpenJDK 20 initialization. |
Description of changes
supporting work:
... and the main event:
cc @edwtjo @asbachb @xeals @Jonpez2
fixes #195638
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes