Skip to content

sparrow: 1.7.0 -> 1.7.1#201321

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
emmanuelrosa:update-sparrow
Dec 4, 2022
Merged

sparrow: 1.7.0 -> 1.7.1#201321
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
emmanuelrosa:update-sparrow

Conversation

@emmanuelrosa
Copy link
Copy Markdown
Contributor

@emmanuelrosa emmanuelrosa commented Nov 15, 2022 •
edited
Loading

Description of changes
  • Since openjdk18 is now marked as insecure, the sparrow package needs to be updated to use openjdk19.
  • This PR also updates Sparrow from 1.7.0 to 1.7.1.
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@emmanuelrosa emmanuelrosa changed the title sparrow: openjdk18 openjdk19 sparrow: openjdk18 to openjdk19 Nov 15, 2022
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 15, 2022
jerith666
jerith666 reviewed Nov 15, 2022
View reviewed changes
@ofborg ofborg bot requested a review from 1000101 November 16, 2022 07:08
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 16, 2022
@emmanuelrosa emmanuelrosa marked this pull request as ready for review November 30, 2022 13:08
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 30, 2022
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Dec 4, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1504

@SuperSandro2000 SuperSandro2000 changed the title sparrow: openjdk18 to openjdk19 sparrow: 1.7.0 -> 1.7.1 Dec 4, 2022
@SuperSandro2000 SuperSandro2000 merged commit d41aca6 into NixOS:master Dec 4, 2022
@emmanuelrosa emmanuelrosa deleted the update-sparrow branch December 4, 2022 19:55
@jerith666 jerith666 mentioned this pull request Dec 23, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1000101 1000101 Awaiting requested review from 1000101

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

1 more reviewer

@jerith666 jerith666 jerith666 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emmanuelrosa @nixos-discourse @jerith666 @SuperSandro2000