temurin-bin, openjdk, openjfx: init at 20#232199
Merged
NickCao merged 3 commits intoNixOS:masterfrom Jul 2, 2023
Merged
Conversation
thiagokokada
approved these changes
Jun 18, 2023
trofi
approved these changes
Jun 18, 2023
Member
|
@Sohalt Could you rebase this. I will than merge it as I need it to package the latest version of cryptomator. |
Contributor
|
@Sohalt @bachp This will resolve the merge conflict. You can also find the rebased branch here: https://github.com/tenaf0/nixpkgs/tree/jdk20 , but I have no write access, nor do I want to take away Sohalt's contribution, I just needed this version of java. |
Member
|
Result of 30 packages marked as broken and skipped:
10 packages failed to build:
626 packages built:
|
Contributor
Author
|
Sorry for not getting back to this earlier and thanks for fixing the conflict and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://jdk.java.net/20/release-notes
https://github.com/openjdk/jfx/blob/jfx20/doc-files/release-notes-20.md
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)