Skip to content

display(jsonrpc): prepare for Display v2#25358

Merged
amnn merged 1 commit intomainfrom
amnn/disp-jsonrpc-prep
Mar 10, 2026
Merged

display(jsonrpc): prepare for Display v2#25358
amnn merged 1 commit intomainfrom
amnn/disp-jsonrpc-prep

Conversation

@amnn
Copy link
Copy Markdown
Contributor

@amnn amnn commented Feb 9, 2026

Description

Relax the type of DisplayFieldsResponse to allow values to be arbitrary JSON, instead of just strings, so it can support Display v2 fields.

Test plan

CI

Stack


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • Indexing Framework:

@amnn amnn self-assigned this Feb 9, 2026
@amnn amnn requested a review from a team as a code owner February 9, 2026 14:32
@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env February 9, 2026 14:32 — with GitHub Actions Inactive
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sui-docs Ready Ready Preview, Comment Mar 10, 2026 8:54pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
multisig-toolkit Ignored Ignored Preview Mar 10, 2026 8:54pm
sui-kiosk Ignored Ignored Preview Mar 10, 2026 8:54pm

Request Review

@amnn amnn force-pushed the amnn/gql-disp-v2 branch from 6f652c5 to 9fcef6d Compare March 10, 2026 16:49
@amnn amnn force-pushed the amnn/disp-jsonrpc-prep branch from c4b5c6c to b2f6b0c Compare March 10, 2026 16:49
@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env March 10, 2026 16:49 — with GitHub Actions Inactive
@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env March 10, 2026 16:49 — with GitHub Actions Inactive
@amnn amnn force-pushed the amnn/gql-disp-v2 branch from 9fcef6d to acb0f6b Compare March 10, 2026 17:29
@amnn amnn force-pushed the amnn/disp-jsonrpc-prep branch from b2f6b0c to 0b4c7a2 Compare March 10, 2026 17:47
@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env March 10, 2026 17:47 — with GitHub Actions Inactive
Base automatically changed from amnn/gql-disp-v2 to main March 10, 2026 20:45
@amnn amnn force-pushed the amnn/disp-jsonrpc-prep branch from 0b4c7a2 to 36c96ff Compare March 10, 2026 20:46
@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env March 10, 2026 20:47 — with GitHub Actions Inactive
## Description

Relax the type of `DisplayFieldsResponse` to allow values to be
arbitrary JSON, instead of just strings, so it can support Display v2
fields.

## Test plan

CI
@amnn amnn force-pushed the amnn/disp-jsonrpc-prep branch from 36c96ff to 6cf585d Compare March 10, 2026 20:47
@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env March 10, 2026 20:47 — with GitHub Actions Inactive
@amnn amnn enabled auto-merge (squash) March 10, 2026 20:48
@amnn amnn merged commit 853ffa6 into main Mar 10, 2026
60 checks passed
@amnn amnn deleted the amnn/disp-jsonrpc-prep branch March 10, 2026 21:13
amnn added a commit that referenced this pull request Mar 10, 2026
## Description
Replicate the GraphQL alt integration for JSONRPC-alt.

## Test plan

New E2E tests:

```
cargo nextest run              \
  -p sui-indexer-alt-e2e-tests \
  --test transactional_tests   \
  -- jsonrpc/objects/display/display_v2
```

## Stack

- #23710 
- #25242
- #25358 

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] gRPC:
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] Indexing Framework:
amnn added a commit that referenced this pull request Mar 11, 2026
## Description

Add support to legacy JSONRPC for Display v2.

## Test plan

New E2E tests:

```
$ cargo nextest run -p sui-json-rpc-tests --test rpc_server_tests
```

## Stack

- #23710 
- #25242
- #25358 
- #25359 

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] gRPC:
- [x] JSON-RPC: Adds support for Display Registry to JSONRPC: When
`showDisplay` is set, the RPC will look for a `Display<T>` stored in the
Display Registry and will use that as the source of truth for its type's
format. This takes precedence over any Display v1 formats that exist for
this type.
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] Indexing Framework:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants