Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
4a48f9a to
dc00abf
Compare
21fdcad to
858829c
Compare
dc00abf to
f0dfa98
Compare
858829c to
b3b6574
Compare
b3b6574 to
a3cbbe5
Compare
a3cbbe5 to
6f652c5
Compare
This was referenced Feb 9, 2026
henryachen
approved these changes
Feb 12, 2026
henryachen
reviewed
Feb 12, 2026
## Description GraphQL will look for and preference `sui::display_registry::Display<T>` over `sui::display::Display<T>` (+ its events) when computing the Display output for a given Move Value. ## Test plan New E2E tests: ``` $ cargo nextest run \ -p sui-indexer-alt-e2e-tests \ --test transactional_tests \ -- display_v2 ```
amnn
added a commit
that referenced
this pull request
Mar 10, 2026
## Description Relax the type of `DisplayFieldsResponse` to allow values to be arbitrary JSON, instead of just strings, so it can support Display v2 fields. ## Test plan CI ## Stack - #23710 - #25242 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
amnn
added a commit
that referenced
this pull request
Mar 10, 2026
## Description Replicate the GraphQL alt integration for JSONRPC-alt. ## Test plan New E2E tests: ``` cargo nextest run \ -p sui-indexer-alt-e2e-tests \ --test transactional_tests \ -- jsonrpc/objects/display/display_v2 ``` ## Stack - #23710 - #25242 - #25358 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
amnn
added a commit
that referenced
this pull request
Mar 11, 2026
## Description Add support to legacy JSONRPC for Display v2. ## Test plan New E2E tests: ``` $ cargo nextest run -p sui-json-rpc-tests --test rpc_server_tests ``` ## Stack - #23710 - #25242 - #25358 - #25359 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [x] JSON-RPC: Adds support for Display Registry to JSONRPC: When `showDisplay` is set, the RPC will look for a `Display<T>` stored in the Display Registry and will use that as the source of truth for its type's format. This takes precedence over any Display v1 formats that exist for this type. - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GraphQL will look for and preference
sui::display_registry::Display<T>oversui::display::Display<T>(+ its events) when computing the Display output for a given Move Value.Test plan
New E2E tests:
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
MoveValue.displaywill look for aDisplay<T>stored in the Display Registry and will use that as the source of truth for its type's format. This takes precedence over any Display v1 formats that exist for this type.