Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1ee7873 to
f67d77d
Compare
damirka
reviewed
Sep 24, 2025
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Outdated
Show resolved
Hide resolved
damirka
reviewed
Sep 24, 2025
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Outdated
Show resolved
Hide resolved
damirka
reviewed
Sep 24, 2025
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Outdated
Show resolved
Hide resolved
damirka
reviewed
Oct 2, 2025
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Outdated
Show resolved
Hide resolved
damirka
reviewed
Oct 2, 2025
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Outdated
Show resolved
Hide resolved
damirka
reviewed
Oct 2, 2025
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Outdated
Show resolved
Hide resolved
damirka
reviewed
Oct 2, 2025
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Outdated
Show resolved
Hide resolved
7 tasks
amnn
reviewed
Oct 14, 2025
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Show resolved
Hide resolved
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Outdated
Show resolved
Hide resolved
manolisliolios
added a commit
that referenced
this pull request
Oct 15, 2025
## Description Introduce all the logic (but not enable) for the creation of Display Registry (`0xd`). This will land before #23710. On that PR, the feature flag will be enabled & will have e2e tests. ## Test plan Just testing that the existing tests pass. **This PR does not do the creation of the object, only sets up the types & logic so we can release in two steps (to avoid breaking indexing)**. Tests for that will be introduced in the PR that enables the feature flag, because the move code is not yet landed (so creation cannot really happen yet!) --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
tnowacki
reviewed
Feb 10, 2026
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Show resolved
Hide resolved
damirka
reviewed
Mar 6, 2026
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Show resolved
Hide resolved
damirka
reviewed
Mar 6, 2026
| } | ||
|
|
||
| #[test_only] | ||
| public(package) fun create_for_testing(ctx: &mut TxContext) { |
Contributor
There was a problem hiding this comment.
I think we're missing a function that returns DisplayRegistry for testing.
Additionally, please make sure to add it to (missed that you've added it already)test_scenario::create_system_objects (this one is easy to miss!)
manolisliolios
commented
Mar 9, 2026
crates/sui-framework/packages/sui-framework/sources/registries/display_registry.move
Show resolved
Hide resolved
amnn
added a commit
that referenced
this pull request
Mar 10, 2026
## Description GraphQL will look for and preference `sui::display_registry::Display<T>` over `sui::display::Display<T>` (+ its events) when computing the Display output for a given Move Value. ## Test plan New E2E tests: ``` $ cargo nextest run \ -p sui-indexer-alt-e2e-tests \ --test transactional_tests \ -- display_v2 ``` ## Stack - #23710 - #25240 - #25241 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [x] GraphQL: Adds support for Display Registry to GraphQL: `MoveValue.display` will look for a `Display<T>` stored in the Display Registry and will use that as the source of truth for its type's format. This takes precedence over any Display v1 formats that exist for this type. - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
amnn
added a commit
that referenced
this pull request
Mar 10, 2026
## Description Relax the type of `DisplayFieldsResponse` to allow values to be arbitrary JSON, instead of just strings, so it can support Display v2 fields. ## Test plan CI ## Stack - #23710 - #25242 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
amnn
added a commit
that referenced
this pull request
Mar 10, 2026
## Description Replicate the GraphQL alt integration for JSONRPC-alt. ## Test plan New E2E tests: ``` cargo nextest run \ -p sui-indexer-alt-e2e-tests \ --test transactional_tests \ -- jsonrpc/objects/display/display_v2 ``` ## Stack - #23710 - #25242 - #25358 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
amnn
added a commit
that referenced
this pull request
Mar 11, 2026
## Description Add support to legacy JSONRPC for Display v2. ## Test plan New E2E tests: ``` $ cargo nextest run -p sui-json-rpc-tests --test rpc_server_tests ``` ## Stack - #23710 - #25242 - #25358 - #25359 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [x] JSON-RPC: Adds support for Display Registry to JSONRPC: When `showDisplay` is set, the RPC will look for a `Display<T>` stored in the Display Registry and will use that as the source of truth for its type's format. This takes precedence over any Display v1 formats that exist for this type. - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces new Display using a registry (similar to coin):
T: key. We can have display for non top-level objects.Display<T>andPublisher, as well as legacy deletion after migration.Why we are doing this?
keyobjects tooTODOS:
0xd(?)display.move) [in a follow-up PR]Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
0xdsystem object is created)