(release_30) fix mccp toggling#425
Merged
vadi2 merged 4 commits intoMudlet:release_30from Mar 16, 2017
Merged
Conversation
(cherry picked from commit c154ef5)
Member
Author
|
@SlySven all ready to be tested! |
Member
|
See my comment on #424 ... |
SlySven
approved these changes
Mar 15, 2017
Member
SlySven
left a comment
There was a problem hiding this comment.
Adopting a suck it and see approach here!
7922a3a added getMudletLuaDefaultPath() that returned a single path, whereas the PR Mudlet#414 changed function to be getMudletLuaDefaultPaths() and made it return an indexed table. This fixes the wrong call that got left behind between cherrypicking and merging.
mehulmathur16
pushed a commit
to mehulmathur16/Mudlet
that referenced
this pull request
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies second patch from https://bugs.launchpad.net/mudlet/+bug/1119884.
Confirmed fixes test case for darklord.evils.in:9100 (create a character and type 'compress' to toggle MCCP on/off)
Confirmed fixes test case in http://www.mudbytes.net/forum/comment/72091/#c72091
Test case works on coffeemud.net port:2323 as well