Skip to content

(release_30) Undo call to getMudletLuaDefaultPath()#421

Merged
vadi2 merged 1 commit intoMudlet:release_30from
vadi2:(release_30)-remove-getMudletLuaDefaultPath
Mar 15, 2017
Merged

(release_30) Undo call to getMudletLuaDefaultPath()#421
vadi2 merged 1 commit intoMudlet:release_30from
vadi2:(release_30)-remove-getMudletLuaDefaultPath

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Mar 13, 2017

7922a3a added getMudletLuaDefaultPath() that returned a single path, whereas the PR #414 changed function to be getMudletLuaDefaultPaths() and made it return an indexed table.

This fixes the wrong call that got left behind between cherrypicking and merging.

7922a3a added getMudletLuaDefaultPath() that returned a single path, whereas the PR Mudlet#414 changed function to be getMudletLuaDefaultPaths() and made it return an indexed table. This fixes the wrong call that got left behind between cherrypicking and merging.
@vadi2 vadi2 requested review from SlySven and keneanung March 13, 2017 01:56
Copy link
Copy Markdown
Member

@keneanung keneanung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Mar 15, 2017

Pretty trivial fix so I'll assume @SlySven is OK with it too, let me know if that's not the case.

Now that there's 3 people who can do reviews, we should figure out how we want this system to work...

@vadi2 vadi2 merged commit 05a1d90 into Mudlet:release_30 Mar 15, 2017
vadi2 added a commit to vadi2/Mudlet that referenced this pull request Mar 16, 2017
7922a3a added getMudletLuaDefaultPath() that returned a single path, whereas the PR Mudlet#414 changed function to be getMudletLuaDefaultPaths() and made it return an indexed table. This fixes the wrong call that got left behind between cherrypicking and merging.
@vadi2 vadi2 deleted the (release_30)-remove-getMudletLuaDefaultPath branch March 16, 2017 03:49
keneanung referenced this pull request in keneanung/Mudlet-1 Mar 21, 2017
7922a3a added getMudletLuaDefaultPath() that returned a single path, whereas the PR #414 changed function to be getMudletLuaDefaultPaths() and made it return an indexed table. This fixes the wrong call that got left behind between cherrypicking and merging.
mehulmathur16 pushed a commit to mehulmathur16/Mudlet that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants