(dev) Fix cmake build to use C++11 as well#420
Conversation
This necessitated updating minimum CMake version to one released in 2014 which I don't think would be an issue.
| ELSE() | ||
| CMAKE_MINIMUM_REQUIRED(VERSION 2.8.9) | ||
| ENDIF() | ||
| CMAKE_MINIMUM_REQUIRED(VERSION 3.1) |
There was a problem hiding this comment.
Are you absolutely sure you HAVE to have 3.1 on all platforms (given that we only have 2.8.11.2 on the Linux Travis CI Platform)
| ENDIF() | ||
| ENDIF() | ||
|
|
||
| set(CMAKE_CXX_STANDARD 11) |
There was a problem hiding this comment.
💡 As I understand it this requires CMake 3.1 (see above) however it might be possible to code around this {see this answer on Stack Exchange}...
There was a problem hiding this comment.
CMake 3.1 came out in 2014, I don't think it is a problem to upgrade to it. I'm sure we can find a PPA for Travis to use.
I don't want to add workarounds for ancient software, let's start using the new stuff!
There was a problem hiding this comment.
Fair enough - but I think it already is!
Checking ./CI/travis.linux/before_install.sh:
#!/bin/bash
set -ev
sudo apt-add-repository ppa:ubuntu-sdk-team/ppa -y
# The ubuntu team have relocated the old qt 5.0.2 (and other things) from the above to:
sudo apt-add-repository ppa:canonical-qt5-edgers/ubuntu1204-qt5 -y
sudo apt-add-repository ppa:kalakris/cmake -y
# newer GCC version, 4.7
sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y
sudo add-apt-repository ppa:boost-latest/ppa -y
sudo apt-get update
pushd $HOME
git clone https://github.com/lloyd/yajl.git
popd
There has not been any later updates to https://launchpad.net/~kalakris/+archive/ubuntu/cmake/+packages
There was a problem hiding this comment.
Well... we'll add a better PPA. We have the technology!
(and if not I'll add the workaround, ok)
SlySven
left a comment
There was a problem hiding this comment.
Consider a workaround to keep Travis working on the Linux-GCC-CMake combination.
|
Bother - we need to install/replace
🪲 Current install phase fails because |
Remove default packages that come with precise by default on travis, as we'd like to upgrade it to cmake from ppa (which does not use a corresponding cmake-data)
|
Well, that'll probably work - I'm just surprised you didn't just add |
|
Puzzling, the Travis CI is not picking up on the changes and I cannot see how to get it to recognise that a new commit has hit the PR and to thus rerun. Notably I somehow copied the Mudlet repository badge/code into my own repository and when I push to my repo Travis runs on it there as well as (redundantly perhaps) also running on the same code in the Mudlet Repository. Or it could be that there is a current situation on Travis according to the Status page.
|
|
Don't worry, it's running if you go to the Travis website. Mind reviewing
the other PR that's ready?
…On Mon, 13 Mar 2017 8:53 pm Stephen Lyons, ***@***.***> wrote:
Puzzling, the Travis CI is not picking up on the changes and I cannot see
how to get it to recognise that a new commit has hit the PR and to thus
rerun. Notably I somehow copied the Mudlet repository badge/code into my
own repository and when I push to *my* repo Travis runs on it there as
well as (redundantly perhaps) also running on the same code in the Mudlet
Repository.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#420 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAGxjEcX2qDj5blyggLm6e90wRPVhGzVks5rlZ62gaJpZM4MawoM>
.
|
|
Expected Linux CI builds have now succeeded (MacOS ones are caught up in daily backlog due around this time but worked in the first commit) so Okaying this PR. I cannot recall but I do not think we mandate C++11 in the release_30 branch - otherwise we'd want the same Travis CI changes in there as well. |
This necessitated updating minimum CMake version to one released in 2014 which I don't think would be an issue.