Merged
Conversation
Member
Author
|
@SlySven all ready to be tested! |
Member
|
I'm not really a person who can test this - I do not have enough idea about mccp to know whether it is behaving or not and to diagnose the latter if it should happen. Is @keneanung a better person to review/approve this? |
Member
|
My knowledge about MCCP is non-existant as well 😞 |
Member
Author
|
Well I've verified that it works and didn't break anything that I tested it
with. Mark as approved it meets the code style I suppose as we don't have
an expert on hand.
…On Wed, 15 Mar 2017 9:42 pm Stephen Lyons, ***@***.***> wrote:
I'm not really a person who can test this - I do not have enough idea
about *mccp* to know whether it is behaving or not and to diagnose the
latter if it should happen. Is @keneanung <https://github.com/keneanung>
a better person to review/approve this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#424 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAGxjN7SlPqAVCucJySK4mC9ri8SNiBiks5rmE00gaJpZM4McHFY>
.
|
SlySven
approved these changes
Mar 15, 2017
Member
SlySven
left a comment
There was a problem hiding this comment.
OK, then, publish and get blamed...
(cherry picked from commit 72715c9)
mehulmathur16
pushed a commit
to mehulmathur16/Mudlet
that referenced
this pull request
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies second patch from https://bugs.launchpad.net/mudlet/+bug/1119884.
Confirmed fixes test case for darklord.evils.in:9100 (create a character and type 'compress' to toggle MCCP on/off)
Confirmed fixes test case in http://www.mudbytes.net/forum/comment/72091/#c72091
Test case works on coffeemud.net port:2323 as well