Skip to content

BugFix: use Alternative OpenSSLBinary for Windows#1850

Merged
SlySven merged 3 commits intoMudlet:developmentfrom
SlySven:BugFix_useAlternativeOpenSSLBinaryForWindows
Jul 27, 2018
Merged

BugFix: use Alternative OpenSSLBinary for Windows#1850
SlySven merged 3 commits intoMudlet:developmentfrom
SlySven:BugFix_useAlternativeOpenSSLBinaryForWindows

Conversation

@SlySven
Copy link
Copy Markdown
Member

@SlySven SlySven commented Jul 26, 2018

The https://indy.fulgan.com site has started to not allow access to the archives for some reason - this should use a suitable alternative.

This will close #1849 if the resulting Windows CI build works for Windows users.

Signed-off-by: Stephen Lyons slysven@virginmedia.com

The indy.fulgan.com site has started to not allow access to the archives
for some reason - this should use a suitable alternative.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

function InstallOpenssl() {
DownloadFile "https://indy.fulgan.com/SSL/openssl-1.0.2o-i386-win32.zip" "openssl-1.0.2o-i386-win32.zip"
# Old source was getting intermittant: DownloadFile "https://indy.fulgan.com/SSL/openssl-1.0.2o-i386-win32.zip" "openssl-1.0.2o-i386-win32.zip"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove that comment. If we want to check the history, we can use git for that and if you use a nice commit message, we have that info as well.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Copy link
Copy Markdown
Member

@keneanung keneanung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@SlySven
Copy link
Copy Markdown
Member Author

SlySven commented Jul 26, 2018

Ok, and it does seem to build - let's hope it tests out okay in practice (or rather on #mudlet-testers)...!

@SlySven SlySven merged commit 53ddd9e into Mudlet:development Jul 27, 2018
SlySven added a commit to SlySven/Mudlet that referenced this pull request Aug 2, 2018
# By Vadim Peretokin (81) and others
* development: (162 commits)
  BugFix: set Server Encoding correctly on auto-loading profiles
  Install xz-utils to guarantee xz is available
  Create and upload source tarballs on release
  BugFix: use Alternative OpenSSLBinary for Windows (Mudlet#1850)
  Fix auto-save kicking in and blocking save profile as
  Upgrade a few classes to newer Qt connect style (Mudlet#1846)
  Fix package exporter to work with async save (Mudlet#1832)
  Pulled out actions into a mudlet member class variables (Mudlet#1839)
  Create module zip if it's not already created when syncing (Mudlet#1842)
  i18n-ise GUI label creation (Mudlet#1838)
  Align "no map"message in centre propely (Mudlet#1837)
  New Crowdin translations (Mudlet#1756)
  Delete old version checks (Mudlet#1833)
  Re-set dev.
  3.11.1 bugfix release.
  Fix iterator to actually iterate
  BugFix: fix faulty log options for new profiles or old profile save files
  Big5 support (Mudlet#1808)
  BugFix: include a fail-back icon for the auto-saved profile in Con. Dialog
  Back to development we go!
  ...

Conflicts resolved in:
* src/TTextEdit.cpp
* src/TTextEdit.h

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven added a commit to SlySven/Mudlet that referenced this pull request Jun 22, 2020
# By Vadim Peretokin (24) and others
# Via keneanung
* development: (52 commits)
  Install xz-utils to guarantee xz is available
  Create and upload source tarballs on release
  BugFix: use Alternative OpenSSLBinary for Windows (Mudlet#1850)
  Fix auto-save kicking in and blocking save profile as
  Upgrade a few classes to newer Qt connect style (Mudlet#1846)
  Fix package exporter to work with async save (Mudlet#1832)
  Pulled out actions into a mudlet member class variables (Mudlet#1839)
  Create module zip if it's not already created when syncing (Mudlet#1842)
  i18n-ise GUI label creation (Mudlet#1838)
  Align "no map"message in centre propely (Mudlet#1837)
  New Crowdin translations (Mudlet#1756)
  Delete old version checks (Mudlet#1833)
  Re-set dev.
  3.11.1 bugfix release.
  Fix iterator to actually iterate
  BugFix: fix faulty log options for new profiles or old profile save files
  Big5 support (Mudlet#1808)
  BugFix: include a fail-back icon for the auto-saved profile in Con. Dialog
  Back to development we go!
  3.11.0 release
  ...

Conflicts resolved in:
* src/dlgProfilePreferences.cpp
* src/mudlet.qrc

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
@SlySven SlySven deleted the BugFix_useAlternativeOpenSSLBinaryForWindows branch June 22, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unavailability of openSSL causing Intermittant failures in AppVeyor CI builds [Windows]

3 participants