Pulled out actions into a mudlet member class variables#1839
Merged
vadi2 merged 2 commits intoMudlet:developmentfrom Jul 24, 2018
Merged
Pulled out actions into a mudlet member class variables#1839vadi2 merged 2 commits intoMudlet:developmentfrom
vadi2 merged 2 commits intoMudlet:developmentfrom
Conversation
Kebap
approved these changes
Jul 21, 2018
Contributor
Kebap
left a comment
There was a problem hiding this comment.
Can't find any ui problems
SlySven
reviewed
Jul 22, 2018
Member
SlySven
left a comment
There was a problem hiding this comment.
On the whole it moves things forward a little...
... and for buttons with tool-tips that are more than around four words I'd recommend converting them to HTML wrapped ones!
src/mudlet.h
Outdated
| QPointer<QAction> mpActionTimers; | ||
| QPointer<QAction> mpActionTriggers; | ||
| QPointer<QAction> mpActionVariables; | ||
| QPointer<QAction> mpActionStopAllTriggers; |
Member
There was a problem hiding this comment.
ℹ️ This one is cruft - it is never shown - and is I think a relic of very old, only one profile at a time code - the stop all triggers code is now a per profile thing and is a button on the main TConsole's bottom tool-bar for the profile.
Member
Author
|
Got rid of the unneeded button. I think the tooltips can stay as-is for now |
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Aug 2, 2018
# By Vadim Peretokin (81) and others * development: (162 commits) BugFix: set Server Encoding correctly on auto-loading profiles Install xz-utils to guarantee xz is available Create and upload source tarballs on release BugFix: use Alternative OpenSSLBinary for Windows (Mudlet#1850) Fix auto-save kicking in and blocking save profile as Upgrade a few classes to newer Qt connect style (Mudlet#1846) Fix package exporter to work with async save (Mudlet#1832) Pulled out actions into a mudlet member class variables (Mudlet#1839) Create module zip if it's not already created when syncing (Mudlet#1842) i18n-ise GUI label creation (Mudlet#1838) Align "no map"message in centre propely (Mudlet#1837) New Crowdin translations (Mudlet#1756) Delete old version checks (Mudlet#1833) Re-set dev. 3.11.1 bugfix release. Fix iterator to actually iterate BugFix: fix faulty log options for new profiles or old profile save files Big5 support (Mudlet#1808) BugFix: include a fail-back icon for the auto-saved profile in Con. Dialog Back to development we go! ... Conflicts resolved in: * src/TTextEdit.cpp * src/TTextEdit.h Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Jun 22, 2020
# By Vadim Peretokin (24) and others # Via keneanung * development: (52 commits) Install xz-utils to guarantee xz is available Create and upload source tarballs on release BugFix: use Alternative OpenSSLBinary for Windows (Mudlet#1850) Fix auto-save kicking in and blocking save profile as Upgrade a few classes to newer Qt connect style (Mudlet#1846) Fix package exporter to work with async save (Mudlet#1832) Pulled out actions into a mudlet member class variables (Mudlet#1839) Create module zip if it's not already created when syncing (Mudlet#1842) i18n-ise GUI label creation (Mudlet#1838) Align "no map"message in centre propely (Mudlet#1837) New Crowdin translations (Mudlet#1756) Delete old version checks (Mudlet#1833) Re-set dev. 3.11.1 bugfix release. Fix iterator to actually iterate BugFix: fix faulty log options for new profiles or old profile save files Big5 support (Mudlet#1808) BugFix: include a fail-back icon for the auto-saved profile in Con. Dialog Back to development we go! 3.11.0 release ... Conflicts resolved in: * src/dlgProfilePreferences.cpp * src/mudlet.qrc Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Pulled out actions into a mudlet member class variables, similar to what #1334 did previously.
Motivation for adding to Mudlet
So they can be addressed directly for i18n.
Other info (issues closed, discussion etc)
I know that
enableToolbarButtonscan be improved - that can be done later.