[Hotfix] /4.0.1 NFT improvement#3657
Conversation
* Refactor RPC Methods * Migrate to typescript * Improve selectedAddress code * Implement Swappable proxy for provider * Fix url on rpc methods * Fix app version code * Temporarily fix Typescript issues on RPCMethodMiddleware * Remove Beta Co-authored-by: Cal Leung <cleun007@gmail.com>
|
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 1 out of 2 committers have signed the CLA.
|
gantunesr
left a comment
There was a problem hiding this comment.
LGTM. I'll give it another look tomorrow morning just in case I missed something
There was a problem hiding this comment.
Issue 1.
With NFT auto detection turned off when i try to manually import my NFT, nothing happens. http://recordit.co/yLvEmxe7pP
to reproduce:
log in to your wallet
tap on the NFT tab
do not turn on NFT token detection but toggle on “enable OpenSea API”.
Import an NFT in your wallet
notice the NFT does not import.
I killed the app and relaunch and the NFT does not appear.
second set of reproduction steps if the above does not work:
log in to your wallet
tap on the NFT tab
toggle on NFT token detection
remove one of your NFT’s.
toggle token detection off.
import the NFT you removed.
notice the NFT does not import.
Issue 2.
The NFT auto-detection message appears on the import tokens view: https://www.screencast.com/t/2Fzobx9l4gql
Issue 3. (being nit picky here.)
going to the NFT detection toggle on the privacy & settings view is not as fluid compared to going to the enhance detection toggle on the experimental view.
NFT detection toggle: http://recordit.co/5InmXTVJmS
Token detection toggle: http://recordit.co/Q3qj6Fhzrv
Potential Issue 4.
This happened to me a couple times when i first started testing. Now I can no longer reproduce. Can you look into it and ensure it is not an issue:
when NFT auto detection is switched on, it only imports your first (oldest) NFT. The other NFT's do not import.
to reproduce:
log in to your wallet
tap on the NFT tab
turn on NFT token detection. Notice your first NFT imports
notice the other NFT’s does not import.
unfortunately I cannot provide a recording. But it did happen.
| {isMainNet(chainId) && !dismissNftInfo && !useCollectibleDetection && ( | ||
| <View style={styles.infoWrapper}> | ||
| <CollectibleDetectionModal onDismiss={this.dismissNftInfo} navigation={navigation} /> | ||
| </View> | ||
| )} |
There was a problem hiding this comment.
This is one of the bugs reported. It's necessary to have a conditional as the one below.
{assetType === 'token' ? (
//...
) : (
//...
)}
Description
Write a short description of the changes included in this pull request.
Checklist
Issue
Resolves #???