Skip to content

[FIX] Dismiss keyboard correctly#3644

Merged
gantunesr merged 5 commits into
mainfrom
fix/request-payment-keyboard-dismiss
Jan 26, 2022
Merged

[FIX] Dismiss keyboard correctly#3644
gantunesr merged 5 commits into
mainfrom
fix/request-payment-keyboard-dismiss

Conversation

@gantunesr

@gantunesr gantunesr commented Jan 25, 2022

Copy link
Copy Markdown
Member

Add keyboardShouldPersistTaps as handled to allow child components to be interactive.

Issue #3609

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking Code Impact - Low Minor code change that can safely applied to the codebase labels Jan 25, 2022
@gantunesr gantunesr requested a review from a team as a code owner January 25, 2022 23:44
Cal-L
Cal-L approved these changes Jan 26, 2022
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr changed the base branch from develop to main January 26, 2022 18:30
@cortisiko cortisiko removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 26, 2022
@gantunesr gantunesr merged commit 5287ec4 into main Jan 26, 2022
@gantunesr gantunesr deleted the fix/request-payment-keyboard-dismiss branch January 26, 2022 23:54
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

Code Impact - Low Minor code change that can safely applied to the codebase Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gantunesr @Cal-L @cortisiko