Skip to content

[FIX] Update warning image#3649

Merged
gantunesr merged 6 commits into
mainfrom
fix/srp-warning-img
Jan 26, 2022
Merged

[FIX] Update warning image#3649
gantunesr merged 6 commits into
mainfrom
fix/srp-warning-img

Conversation

@gantunesr

@gantunesr gantunesr commented Jan 26, 2022

Copy link
Copy Markdown
Member

Description

Update 'Skip Account security?' modal warning image.

Old Image New Image

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking Code Impact - Low Minor code change that can safely applied to the codebase labels Jan 26, 2022
@gantunesr gantunesr requested a review from a team as a code owner January 26, 2022 13:39
rickycodes
rickycodes suggested changes Jan 26, 2022
View reviewed changes

@rickycodes rickycodes left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding this new PNG I suggest we delete it and use <FeatherIcon name="alert-triangle" size={...} /> which is the same and used elsewhere. wdyt?

@gantunesr

gantunesr commented Jan 26, 2022

Copy link
Copy Markdown
Member Author

@rickycodes done! (b64f8da)

Screen Shot 2022-01-26 at 14 37 34

@gantunesr gantunesr requested a review from rickycodes January 26, 2022 17:42
@gantunesr gantunesr changed the base branch from develop to main January 26, 2022 18:30
@cortisiko cortisiko removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 26, 2022
Cal-L
Cal-L approved these changes Jan 26, 2022
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit 1358228 into main Jan 26, 2022
@gantunesr gantunesr deleted the fix/srp-warning-img branch January 26, 2022 22:40
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

+1 more reviewer

@rickycodes rickycodes rickycodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Code Impact - Low Minor code change that can safely applied to the codebase Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gantunesr @rickycodes @Cal-L @cortisiko