Skip to content

[FIX] use empty string quotes for anon id#3144

Merged
sethkfman merged 5 commits into
developfrom
metametrics-fix-id
Nov 16, 2021
Merged

[FIX] use empty string quotes for anon id#3144
sethkfman merged 5 commits into
developfrom
metametrics-fix-id

Conversation

@brad-decker

@brad-decker brad-decker commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

Uses the "" value for anonymous ids that is mixpanels undocumented standard for treating truly anonymous events. The previous value, and anything other than this, cause all events for that id to be stored in a single cluster and significantly increases overhead on dashboards and queries.

Remaining items:

  • Build locally and test on development
  • Ensure proper passing of "" value to mixpanel

@gantunesr gantunesr marked this pull request as ready for review November 16, 2021 17:52
@gantunesr gantunesr requested a review from a team as a code owner November 16, 2021 17:52
@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 16, 2021
@sethkfman sethkfman changed the title use empty string quotes for anon id [FIX] use empty string quotes for anon id Nov 16, 2021

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 16, 2021
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 16, 2021
@sethkfman sethkfman merged commit fa5677e into develop Nov 16, 2021
@sethkfman sethkfman deleted the metametrics-fix-id branch November 16, 2021 20:10
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

next release No QA Needed Apply this label when your PR does not need any QA effort.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants