Use async/await for seedPhraseVerifier.verifyAccounts#9100
Merged
whymarrh merged 1 commit intoMetaMask:developfrom Jul 29, 2020
Merged
Use async/await for seedPhraseVerifier.verifyAccounts#9100whymarrh merged 1 commit intoMetaMask:developfrom
whymarrh merged 1 commit intoMetaMask:developfrom
Conversation
b001da2 to
383b764
Compare
danjm
approved these changes
Jul 29, 2020
Contributor
danjm
left a comment
There was a problem hiding this comment.
All code remains the same except for the promise+resolve+reject -> async/await switch. So LGTM
brad-decker
approved these changes
Jul 29, 2020
Gudahtt
added a commit
that referenced
this pull request
Jul 30, 2020
* origin/develop: (582 commits) Use async/await for seedPhraseVerifier.verifyAccounts (#9100) Use async/await for getRestrictedMethods (#9099) Update dependencies (#9105) update email us to contact us (#9104) Improve source maps (#9101) Update font family globally (#9073) rpc-cap@3.1.0 (#9103) Use environment variable for production Sentry DSN (#9097) Only log error on first occurrence of missing substitution (#9096) Use mixins for typography instead of placeholder selectors (#9072) Update css folder structure (#9071) Disable Sentry in development (#9095) Use environment variable for MetaMetrics project ID (#9094) Use development metametrics project during tests (#9093) json-rpc-engine@5.2.0 (#9091) fixup! call initializeProvider where necessary call initializeProvider where necessary Add euclid fontface (#9018) fix timing-reliant network controller test Robustify permissions controller requestUserApproval tests (#9064) ...
Gudahtt
pushed a commit
that referenced
this pull request
Aug 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
seedPhraseVerifier.verifyAccountsto use async/await in line with most of the background scripts.The result of the method call (which is now
Promise<undefined>instead ofundefined) is not used by its call site.[1](Hide whitespace changes might be useful for this diff.)