Skip to content

Use environment variable for MetaMetrics project ID#9094

Merged
Gudahtt merged 1 commit intodevelopfrom
use-metametrics-environment-variables
Jul 28, 2020
Merged

Use environment variable for MetaMetrics project ID#9094
Gudahtt merged 1 commit intodevelopfrom
use-metametrics-environment-variables

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jul 28, 2020

The MetaMetrics project ID can now be set via environment variable. It has not been set yet in practice, so for now the old project IDs will still be used. This is in preparation for migrating to a new project.

The MetaMetrics project ID can now be set via environment variable. It
has not been set yet in practice, so for now the old project IDs will
still be used. This is in preparation for migrating to a new project.
@Gudahtt Gudahtt requested review from a team and kumavis as code owners July 28, 2020 18:57
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [13db2fa]
Page Load Metrics (603 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3092472210
domContentLoaded35075960111153
load35576160311053
domInteractive35075960111153

Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 8a7c8e8 into develop Jul 28, 2020
@Gudahtt Gudahtt deleted the use-metametrics-environment-variables branch July 28, 2020 19:59
Gudahtt added a commit that referenced this pull request Jul 30, 2020
* origin/develop: (582 commits)
  Use async/await for seedPhraseVerifier.verifyAccounts (#9100)
  Use async/await for getRestrictedMethods (#9099)
  Update dependencies (#9105)
  update email us to contact us (#9104)
  Improve source maps (#9101)
  Update font family globally (#9073)
  rpc-cap@3.1.0 (#9103)
  Use environment variable for production Sentry DSN (#9097)
  Only log error on first occurrence of missing substitution (#9096)
  Use mixins for typography instead of placeholder selectors (#9072)
  Update css folder structure (#9071)
  Disable Sentry in development (#9095)
  Use environment variable for MetaMetrics project ID (#9094)
  Use development metametrics project during tests (#9093)
  json-rpc-engine@5.2.0 (#9091)
  fixup! call initializeProvider where necessary
  call initializeProvider where necessary
  Add euclid fontface (#9018)
  fix timing-reliant network controller test
  Robustify permissions controller requestUserApproval tests (#9064)
  ...
Gudahtt added a commit that referenced this pull request Aug 7, 2020
The MetaMetrics project ID can now be set via environment variable. It
has not been set yet in practice, so for now the old project IDs will
still be used. This is in preparation for migrating to a new project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants