Merged
Conversation
4c489fc to
4dba1cb
Compare
144e401 to
b37cf34
Compare
Collaborator
Builds ready [b37cf34]
Page Load Metrics (560 ± 37 ms)
|
Contributor
Author
4dba1cb to
0a65568
Compare
b37cf34 to
78d2678
Compare
Collaborator
Builds ready [78d2678]
Page Load Metrics (629 ± 50 ms)
|
|
This looks fantastic, yay! The only one that does not look updated to me is the Create account (after), but it is likely just a wrong screenshot? Very excited about this update 🚀 |
rachelcope
approved these changes
Jul 29, 2020
danjm
approved these changes
Jul 29, 2020
Contributor
danjm
left a comment
There was a problem hiding this comment.
Review code and tested in browser. LGTM
rekmarks
approved these changes
Jul 29, 2020
Gudahtt
added a commit
that referenced
this pull request
Jul 30, 2020
* origin/develop: (582 commits) Use async/await for seedPhraseVerifier.verifyAccounts (#9100) Use async/await for getRestrictedMethods (#9099) Update dependencies (#9105) update email us to contact us (#9104) Improve source maps (#9101) Update font family globally (#9073) rpc-cap@3.1.0 (#9103) Use environment variable for production Sentry DSN (#9097) Only log error on first occurrence of missing substitution (#9096) Use mixins for typography instead of placeholder selectors (#9072) Update css folder structure (#9071) Disable Sentry in development (#9095) Use environment variable for MetaMetrics project ID (#9094) Use development metametrics project during tests (#9093) json-rpc-engine@5.2.0 (#9091) fixup! call initializeProvider where necessary call initializeProvider where necessary Add euclid fontface (#9018) fix timing-reliant network controller test Robustify permissions controller requestUserApproval tests (#9064) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
font: inheritwith the individual properties except forfont-familyin reset.scssfont-family:styles set elsewhere.Depends on:
Add euclid fontface #9018Update css folder structure #9071Use mixins for typography instead of placeholder selectors #9072Screenshot Samples
This doesn't represent all of the changes, given the wide target for this PR, but it should give an idea of the scope and quality of the changes. If you'd like to do a full audit, see the latest comment from @metamaskbot to get the build and install it locally. Or checkout this branch and build for dev mode.
Lock screen
Before
After
Home
Before
After
Activity List
Before
After
Asset list
Before
After
Main Menu
Before
After
Create Account
Before
After
Settings Page
Before
After
Connected Sites modal
Before
After