Updates Typography Variables and styles. #9017
Conversation
a09affa to
5e50162
Compare
ffcf6d3 to
06acab2
Compare
06acab2 to
5bce8b8
Compare
Builds ready [5bce8b8]
Page Load Metrics (590 ± 39 ms)
|
Gudahtt
left a comment
There was a problem hiding this comment.
Looks good overall - I had a couple of minor comments.
There remain some possible user-facing changes this could cause that are difficult to find by reading the styles, so... we might want to include a complete UI review as part of whichever release this lands in.
| %H4 { | ||
| font-style: normal; | ||
| font-weight: normal; | ||
| font-size: 1.125rem; |
There was a problem hiding this comment.
I noticed that the old placeholder selectors (e.g. %h4) also set the line-height. Was that omitted here intentionally?
There was a problem hiding this comment.
I added the line heights from the design system but I did not modify any setting of extra line-heights to help mitigate as many user-facing changes as possible in this PR.
| } | ||
|
|
||
| %H4 { | ||
| font-style: normal; |
There was a problem hiding this comment.
This was omitted from the old placeholder selectors. Was this addition intentional, and is this possible this could result in a user-facing change? 🤔
There was a problem hiding this comment.
I guess the same goes for font-family as well
There was a problem hiding this comment.
For the most part I tried to make sure that the changes I made resulted in very close to the original styling, but because of the nature of CSS, it's possible that due to cascades setting font-style: normal; might override a cascaded font-style from a parent. I think a UI review is probably in order as you mentioned in you review comment. All the typography styles in the design system specify font-style which is why I specified it here.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Builds ready [88bcded]
Page Load Metrics (564 ± 41 ms)
|
Depends on [
Define Design System Colors #9007,Narrow usages of 037DD6 to 'primary-blue' #9008,Add accent-color usage from design system. #9009]