Skip to content

Add accent-color usage from design system.#9009

Merged
brad-decker merged 1 commit intodevelopfrom
accent-colors
Jul 21, 2020
Merged

Add accent-color usage from design system.#9009
brad-decker merged 1 commit intodevelopfrom
accent-colors

Conversation

@brad-decker
Copy link
Copy Markdown
Contributor

@brad-decker brad-decker commented Jul 15, 2020

Fixes usage of the accent colors from the design system.

  1. The button component styles referenced a one off color that I worked with @rachelcope in the design channel to find a color system alternative for.
  2. I added a temporary Yellow-000 color variable that we can update later after a Figma comment is responded to regarding the yellow background color of the alert circle icon and highlight color on connected account selection.
  3. Eliminates all of the danger- success- warning- and info- css variables in favor of using the accent colors / color palette colors.
    Depends on : [ Define Design System Colors #9007 , Narrow usages of 037DD6 to 'primary-blue' #9008 ]

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [7e846d7]
Page Load Metrics (661 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27113452211
domContentLoaded5598836599043
load5618846619043
domInteractive5598826599043

@brad-decker brad-decker marked this pull request as ready for review July 17, 2020 18:17
@brad-decker brad-decker requested a review from a team as a code owner July 17, 2020 18:17
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [c50c518]
Page Load Metrics (578 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28403431
domContentLoaded3386645777636
load3396655787636
domInteractive3376635767636

Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 35a6ad9 into develop Jul 21, 2020
@brad-decker brad-decker deleted the accent-colors branch July 21, 2020 16:17
@brad-decker
Copy link
Copy Markdown
Contributor Author

Update fonts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants