Merged
Conversation
7eb7569 to
c1f7487
Compare
Collaborator
Builds ready [6cfcc73]
Page Load Metrics (628 ± 37 ms)
|
This was referenced Jul 16, 2020
Merged
Gudahtt
reviewed
Jul 17, 2020
| $Grey-900: #141618; | ||
|
|
||
| $Green-000: #f3fcf5; | ||
| $Green-100: #d6ffdf; |
Member
There was a problem hiding this comment.
This is listed as different in the Figma 🤔
Suggested change
| $Green-100: #d6ffdf; | |
| $Green-100: #e6f9ea; |
Member
There was a problem hiding this comment.
Yours matches the color used in Figma, but not the written hex code. So I guess yours is correct.
Contributor
Author
There was a problem hiding this comment.
Yeah there were a couple instances of that. We should probably move away from writing the hex value directly on the sheet and instead just use the color variable name. We can figure out the hex values by clicking the swatch
| $Orange-900: #321602; | ||
|
|
||
| $Yellow-100: #fefcde; | ||
| $Yellow-500: #ffd33d; |
Member
There was a problem hiding this comment.
The Figma uses a different color here:
Suggested change
| $Yellow-500: #ffd33d; | |
| $Yellow-500: #f66a0a; |
Member
There was a problem hiding this comment.
Though the Yellow referenced in the figma is #ffd33d 🤔
I guess yours is correct here as well.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Collaborator
Builds ready [df56869]
Page Load Metrics (1030 ± 122 ms)
|
Contributor
Author
2 similar comments
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ui/app/css/variablescolors.scssfile in said folder